public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>
Cc: pmg-devel@pve.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] pmgproxy: allow setting LISTEN_IP parameter
Date: Fri, 11 Jun 2021 17:29:05 +0200	[thread overview]
Message-ID: <20210611172905.57da1a25@rosa.proxmox.com> (raw)
In-Reply-To: <20210324125931.536178-1-o.bektas@proxmox.com>

On Wed, 24 Mar 2021 13:59:31 +0100
Oguz Bektas <o.bektas@proxmox.com> wrote:

> LISTEN_IP is defined in /etc/default/pmgproxy.
> 
> this depends on the changes in pve-common and pve-http-server (#2997)
> 
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PMG/Service/pmgproxy.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PMG/Service/pmgproxy.pm b/src/PMG/Service/pmgproxy.pm
> index b2fdc69..11cefe8 100755
> --- a/src/PMG/Service/pmgproxy.pm
> +++ b/src/PMG/Service/pmgproxy.pm
> @@ -64,8 +64,8 @@ sub init {
>      my $lockfh = IO::File->new(">>${accept_lock_fn}") ||
>  	die "unable to open lock file '${accept_lock_fn}' - $!\n";
>  
> -    my $family = PVE::Tools::get_host_address_family($self->{nodename});
> -    my $socket = $self->create_reusable_socket(8006, undef, $family);
> +    my $listen_ip = $proxyconf->{LISTEN_IP} // "::0";
> +    my $socket = $self->create_reusable_socket(8006, $listen_ip);
>  
>      my $dirs = {};
>  

applied the patch, but pulled in the changes from pve-manager commit
8da3ad7ce8ca9d609f0e5be3860f63f3d1a58889

Huge Thanks!




      reply	other threads:[~2021-06-11 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <99c76ae4-0810-f44d-25c4-3cdf8ce28dc0@proxmox.com>
2021-03-24 12:59 ` [pmg-devel] " Oguz Bektas
2021-06-11 15:29   ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210611172905.57da1a25@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pmg-devel@pve.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal