public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-rs] account: create account files with 0600 permissions
Date: Mon, 29 Mar 2021 14:00:29 +0200	[thread overview]
Message-ID: <20210329120029.2dq5dah6zfrkkas3@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20210329111837.8469-1-s.ivanov@proxmox.com>

applied, thanks

On Mon, Mar 29, 2021 at 01:18:37PM +0200, Stoiko Ivanov wrote:
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> quickly tested on my setup - files get created correctly
> 
>  src/acme.rs | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acme.rs b/src/acme.rs
> index ef6f4e7..4c8e5df 100644
> --- a/src/acme.rs
> +++ b/src/acme.rs
> @@ -3,6 +3,8 @@
>  //! The functions in here are perl bindings.
>  
>  use std::io::{self, Write};
> +use std::fs::OpenOptions;
> +use std::os::unix::fs::OpenOptionsExt;
>  
>  use anyhow::{format_err, Error};
>  use serde::{Deserialize, Serialize};
> @@ -85,7 +87,9 @@ impl Inner {
>          };
>  
>          let _account = self.client.new_account(contact, tos_agreed, rsa_bits)?;
> -        let file = std::fs::File::create(&account_path)
> +        let mut options = OpenOptions::new();
> +        options.write(true).create(true).mode(0o600);
> +        let file = options.open(&account_path)
>              .map_err(|err| format_err!("failed to open {:?} for writing: {}", account_path, err))?;
>          self.write_to(file).map_err(|err| {
>              format_err!(
> @@ -137,7 +141,9 @@ impl Inner {
>  
>          let tmp_path = format!("{}.tmp", account_path);
>          // FIXME: move proxmox::tools::replace_file & make_temp out into a nice *little* crate...
> -        let mut file = std::fs::File::create(&tmp_path)
> +        let mut options = OpenOptions::new();
> +        options.write(true).create(true).mode(0o600);
> +        let mut file = options.open(&tmp_path)
>              .map_err(|err| format_err!("failed to open {:?} for writing: {}", tmp_path, err))?;
>          self.write_to(&mut file).map_err(|err| {
>              format_err!("failed to write acme account to {:?}: {}", tmp_path, err)
> -- 
> 2.20.1




      reply	other threads:[~2021-03-29 12:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 11:18 [pmg-devel] " Stoiko Ivanov
2021-03-29 12:00 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210329120029.2dq5dah6zfrkkas3@wobu-vie.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal