From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Mira Limbeck <m.limbeck@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] applied: [PATCH v2 log-tracker 1/2] after-queue: fix wrong DStatus if relay is 'removed' before 'lmtp' line
Date: Wed, 24 Mar 2021 11:41:36 +0100 [thread overview]
Message-ID: <20210324114136.5d7000ed@rosa.proxmox.com> (raw)
In-Reply-To: <20210323142823.27616-1-m.limbeck@proxmox.com>
On Tue, 23 Mar 2021 15:28:22 +0100
Mira Limbeck <m.limbeck@proxmox.com> wrote:
> We only match a QEntry with the relay Qentry in the after-queue case
> when we get to the 'lmtp' line. This is because it contains a reference
> from the first QEntry to the filter, and the filter contains a reference
> to the relay QEntry.
>
> If the relay log entries are finished before the 'lmtp' line, there's no
> way to match the relay to the first QEntry and we still assume it is
> before-queue filtered.
>
> To fix this we try to match the QEntries via message-id and add weak
> references to each other. Then we wait with finalizing either until the
> other is also 'removed' (finished).
>
> The message-id matching might break if the same message-id is used for
> different entries, so this is rather a 'hack' than a nice solution, but
> there's no other info in the logs we could use to match both QEntries.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
applied both patches - thanks!
prev parent reply other threads:[~2021-03-24 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 14:28 [pmg-devel] " Mira Limbeck
2021-03-23 14:28 ` [pmg-devel] [PATCH v2 log-tracker 2/2] add test case for relay removed before lmtp Mira Limbeck
2021-03-24 10:41 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324114136.5d7000ed@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox