From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 1/2] pbs: api: add statistic parameter to run_backup
Date: Thu, 19 Nov 2020 09:40:53 +0100 [thread overview]
Message-ID: <20201119094053.66c3ab49@rosa.proxmox.com> (raw)
In-Reply-To: <1392664598.271.1605724464296@webmail.proxmox.com>
On Wed, 18 Nov 2020 19:34:23 +0100 (CET)
Dietmar Maurer <dietmar@proxmox.com> wrote:
> why does this default => 1 ?
mostly to mirror the way it is with the local-backup (to tar.gz):
https://git.proxmox.com/?p=pmg-api.git;a=blob;f=src/PMG/API2/Backup.pm;h=4ea28d13e28f23956ec7e0ff64e77ea04a333a53;hb=HEAD#l122
I also think that we should rather backup more than less in the default
case - I personally be more disappointed to lose my year long statistics
in case of disaster than about ~100 M (estimated based on our
productive instance) more space on my backupstorage.
You do have a point regarding size (backup without statistics is usually <
500k vs 100M) though - so making this comfortably configurable would be a
nice enhancement!
Making this actually user-selectable (apart from a direct API-call or
using `pmgbackup` manually) would need exposing this in the GUI (and
somehow getting it in the systemd-service units).
Would recording this in bugzilla work for you?
>
> Statistics are large, and not really required for fully functional restore.
> IMHO, I want backups as small as possible.
>
> > On 11/18/2020 6:59 PM Stoiko Ivanov <s.ivanov@proxmox.com> wrote:
> >
> >
> > Without it the backup does not include the statistics database
> >
> > Reported-by: Martin Maurer <martin@proxmox.com>
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> > src/PMG/API2/PBS/Job.pm | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/src/PMG/API2/PBS/Job.pm b/src/PMG/API2/PBS/Job.pm
> > index 793ad88..a0d942a 100644
> > --- a/src/PMG/API2/PBS/Job.pm
> > +++ b/src/PMG/API2/PBS/Job.pm
> > @@ -266,6 +266,12 @@ __PACKAGE__->register_method ({
> > description => "Proxmox Backup Server ID.",
> > type => 'string', format => 'pve-configid',
> > },
> > + statistic => {
> > + description => "Backup statistic databases.",
> > + type => 'boolean',
> > + optional => 1,
> > + default => 1,
> > + },
> > },
> > },
> > returns => { type => "string" },
> > @@ -284,6 +290,8 @@ __PACKAGE__->register_method ({
> > die "PBS remote '$remote' does not exist\n" if !$remote_config;
> > die "PBS remote '$remote' is disabled\n" if $remote_config->{disable};
> >
> > + $param->{statistic} //= 1;
> > +
> > my $pbs = PVE::PBSClient->new($remote_config, $remote, $conf->{secret_dir});
> > my $backup_dir = "/var/lib/pmg/backup/current";
> >
> > --
> > 2.20.1
> >
> >
> >
> > _______________________________________________
> > pmg-devel mailing list
> > pmg-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2020-11-19 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 17:59 [pmg-devel] [PATCH pmg-api 0/2] PBS integration: include statdb Stoiko Ivanov
2020-11-18 17:59 ` [pmg-devel] [PATCH pmg-api 1/2] pbs: api: add statistic parameter to run_backup Stoiko Ivanov
2020-11-18 18:34 ` Dietmar Maurer
2020-11-19 8:40 ` Stoiko Ivanov [this message]
2020-11-19 9:08 ` Dietmar Maurer
2020-11-18 17:59 ` [pmg-devel] [PATCH pmg-api 2/2] api: pbs: remove state after backup Stoiko Ivanov
2020-11-18 18:25 ` [pmg-devel] applied-series: [PATCH pmg-api 0/2] PBS integration: include statdb Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119094053.66c3ab49@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox