Re: [pmg-devel] [PATCH pmg-api 1/2] pbs: api: add statistic parameter to run_backup

[Stoiko Ivanov <s.ivanov@proxmox.com>]

On Wed, 18 Nov 2020 19:34:23 +0100 (CET)
Dietmar Maurer <dietmar@proxmox.com> wrote:

> why does this default => 1 ?
mostly to mirror the way it is with the local-backup (to tar.gz):
https://git.proxmox.com/?p=pmg-api.git;a=blob;f=src/PMG/API2/Backup.pm;h=4ea28d13e28f23956ec7e0ff64e77ea04a333a53;hb=HEAD#l122

I also think that we should rather backup more than less in the default
case - I personally be more disappointed to lose my year long statistics
in case of disaster than about ~100 M (estimated based on our
productive instance) more space on my backupstorage.
You do have a point regarding size (backup without statistics is usually <
500k vs 100M) though - so making this comfortably configurable would be a
nice enhancement! 

Making this actually user-selectable (apart from a direct API-call or
using `pmgbackup` manually) would need exposing this in the GUI (and
somehow getting it in the systemd-service units).

Would recording this in bugzilla work for you?


> 
> Statistics are large, and not really required for fully functional restore.
> IMHO, I want backups as small as possible.
>  
> > On 11/18/2020 6:59 PM Stoiko Ivanov <s.ivanov@proxmox.com> wrote:
> > 
> >  
> > Without it the backup does not include the statistics database
> > 
> > Reported-by: Martin Maurer <martin@proxmox.com>
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> >  src/PMG/API2/PBS/Job.pm | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/src/PMG/API2/PBS/Job.pm b/src/PMG/API2/PBS/Job.pm
> > index 793ad88..a0d942a 100644
> > --- a/src/PMG/API2/PBS/Job.pm
> > +++ b/src/PMG/API2/PBS/Job.pm
> > @@ -266,6 +266,12 @@ __PACKAGE__->register_method ({
> >  		description => "Proxmox Backup Server ID.",
> >  		type => 'string', format => 'pve-configid',
> >  	    },
> > +	    statistic => {
> > +		description => "Backup statistic databases.",
> > +		type => 'boolean',
> > +		optional => 1,
> > +		default => 1,
> > +	    },
> >  	},
> >      },
> >      returns => { type => "string" },
> > @@ -284,6 +290,8 @@ __PACKAGE__->register_method ({
> >  	die "PBS remote '$remote' does not exist\n" if !$remote_config;
> >  	die "PBS remote '$remote' is disabled\n" if $remote_config->{disable};
> >  
> > +	$param->{statistic} //= 1;
> > +
> >  	my $pbs = PVE::PBSClient->new($remote_config, $remote, $conf->{secret_dir});
> >  	my $backup_dir = "/var/lib/pmg/backup/current";
> >  
> > -- 
> > 2.20.1
> > 
> > 
> > 
> > _______________________________________________
> > pmg-devel mailing list
> > pmg-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel