* [pmg-devel] [PATCH pmg-api] fix #3141: do not split on ', ' for returning the from header
@ 2020-11-18 12:59 Dominik Csapak
2020-11-18 16:03 ` [pmg-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-11-18 12:59 UTC (permalink / raw)
To: pmg-devel
this is only used to display it in the gui, simply return the whole
from header instead of trying to find the first part
this was wrong in case someone sent an email with a from header like:
From: "Csapak, Dominik" <d.csapak@proxmox.com>
which would yield '"Csapak' as from part...
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PMG/API2/Quarantine.pm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/PMG/API2/Quarantine.pm b/src/PMG/API2/Quarantine.pm
index 73fb0ec..750afbe 100644
--- a/src/PMG/API2/Quarantine.pm
+++ b/src/PMG/API2/Quarantine.pm
@@ -131,9 +131,7 @@ my $parse_header_info = sub {
$res->{subject} = PMG::Utils::decode_rfc1522(PVE::Tools::trim($head->get('subject'))) // '';
- my @fromarray = split('\s*,\s*', $head->get('from') || $ref->{sender});
-
- $res->{from} = PMG::Utils::decode_rfc1522(PVE::Tools::trim ($fromarray[0])) // '';
+ $res->{from} = PMG::Utils::decode_rfc1522(PVE::Tools::trim($head->get('from') || $ref->{sender})) // '';
my $sender = PMG::Utils::decode_rfc1522(PVE::Tools::trim($head->get('sender')));
$res->{sender} = $sender if $sender && ($sender ne $res->{from});
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-api] fix #3141: do not split on ', ' for returning the from header
2020-11-18 12:59 [pmg-devel] [PATCH pmg-api] fix #3141: do not split on ', ' for returning the from header Dominik Csapak
@ 2020-11-18 16:03 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-18 16:03 UTC (permalink / raw)
To: Dominik Csapak, pmg-devel
On 18.11.20 13:59, Dominik Csapak wrote:
> this is only used to display it in the gui, simply return the whole
> from header instead of trying to find the first part
>
> this was wrong in case someone sent an email with a from header like:
>
> From: "Csapak, Dominik" <d.csapak@proxmox.com>
>
> which would yield '"Csapak' as from part...
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PMG/API2/Quarantine.pm | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-18 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 12:59 [pmg-devel] [PATCH pmg-api] fix #3141: do not split on ', ' for returning the from header Dominik Csapak
2020-11-18 16:03 ` [pmg-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox