public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pmg-devel@lists.proxmox.com, Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pmg-devel] applied: [PATCH pmg-api] cluster: fingerprint parsing: adapt to changed openssl output
Date: Mon, 24 Jul 2023 15:08:15 +0200	[thread overview]
Message-ID: <1690203866.1eqnyvr7hx.astroid@yuna.none> (raw)
In-Reply-To: <20230724110624.9502-1-s.ivanov@proxmox.com>

could be made more robust by wrapping "read_local_ssl_cert_fingerprint"
somewhere callable via SSH (so that we have a single way of doing file
path -> cert -> fingerprint) but this serves as a stop-gap measure.

I wonder whether we should lower-case the cache (key) in
PVE::APIClient::LWP, to reduce a potentially confusing source of errors?
some tools use aa:bb:.. , some other use AA:BB:.. for fingerprints, but
they are semantically equivalent..

folded in shortening the RE, now that it's case-insensitive anyway we
don't need to match both A-F and a-f ;)

On July 24, 2023 1:06 pm, Stoiko Ivanov wrote:
> currently updating the fingerprints using `pmgcm update-fingerprints`
> runs into an error indicating that parsing of the remote node's
> fingerprint fails
> 
> The error is due to changed output in openssl's x509 command,
> introduced in commit:
> 91034b68b39e3525f09fb263b9272de410a3ba4c
> in openssl upstream [0]
> 
> Note that in that case it would equally work to change the parameter
> from `-sha256` to `-SHA256` in the `openssl x509` command above
> 
> The change seems small enough to warrant pulling it into stable-7 as
> well (although the issue should not occur in systems upgraded
> according to our howtos).
> 
> [0] https://github.com/openssl/openssl/commit/91034b68b39e3525f09fb263b9272de410a3ba4c
> 
> Reported-by: Martin Maurer <martin@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> quickly tested on a cluster of mine.
>  src/PMG/Cluster.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PMG/Cluster.pm b/src/PMG/Cluster.pm
> index e9a6054..c431521 100644
> --- a/src/PMG/Cluster.pm
> +++ b/src/PMG/Cluster.pm
> @@ -307,7 +307,7 @@ sub get_remote_cert_fingerprint {
>      eval {
>  	PVE::Tools::run_command($ssh_cmd, outfunc => sub {
>  	    my ($line) = @_;
> -	    if ($line =~ m/SHA256 Fingerprint=((?:[A-Fa-f0-9]{2}:){31}[A-Fa-f0-9]{2})/) {
> +	    if ($line =~ m/SHA256 Fingerprint=((?:[A-Fa-f0-9]{2}:){31}[A-Fa-f0-9]{2})/i) {
>  		$fp = $1;
>  	    }
>  	});
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> 
> 
> 




      reply	other threads:[~2023-07-24 13:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 11:06 [pmg-devel] " Stoiko Ivanov
2023-07-24 13:08 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1690203866.1eqnyvr7hx.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal