[pmg-devel] applied: [PATCH pmg-api v2] rulesystem: limit linelength of disclaimer to 998 bytes

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 24.11.21 22:00, Stoiko Ivanov wrote:
> As described in
> http://www.postfix.org/postconf.5.html#smtp_line_length_limit
> 
> postfix splits lines which are longer by inserting <cr><lf><space> to
> adhere with RFC 5322 (section 2.1.1):
> https://datatracker.ietf.org/doc/html/rfc5322#section-2.1.1
> (or actually section 4.5.3.1.6. where characters are translated to
> octets)
> 
> If a longer line is part of the disclaimer pmg-smtp-filter adds it
> without this modification, which breaks DKIM signatures (since the
> body is modified by postfix after the body hash is computed)
> 
> regular-expression matching is used instead of length(), because the
> limit is on line-length (and a disclaimer can contain multiple lines)
> 
> reported in our community forum:
> https://forum.proxmox.com/threads/.97919/
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> v2->v1:
> * incorporated Thomas' feedback - huge thanks!
> * replaced the 2/3 occurences of encode('UTF-8',...) by a temporary varialbe

great that it could roughly stay the same amount of work, the memory scan should
be rather cheap.

> * read up quite a bit on the magic world of encoding)
> * verified that the encoded value is indeed the one we want to compare
>   against
> 
>  src/PMG/RuleDB/Disclaimer.pm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
>

applied, thanks!