Re: [pmg-devel] [PATCH pmg-api] pmg-daily: avoid short-circuting update of local channels

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 12/07/2022 um 14:14 schrieb Stoiko Ivanov:
> by using ||= directly with the actual update call as operand, it does
> not get run, if `sa-update` already returned that a restart is needed.
> 
> reported in our community forum:
> https://forum.proxmox.com/threads/.112112/
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/bin/pmg-daily | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/bin/pmg-daily b/src/bin/pmg-daily
> index b06515c..a9bfd1c 100755
> --- a/src/bin/pmg-daily
> +++ b/src/bin/pmg-daily
> @@ -85,7 +85,8 @@ if (system('sa-update') == 0) {
>  }
>  
>  eval {
> -    $restart_filter ||= PMG::Utils::update_local_spamassassin_channels(0);
> +    my $res ||= PMG::Utils::update_local_spamassassin_channels(0);

||= makes not much sense for a newly declared variable, just use plain assignment please.

Alternatively you could also just do:

$restart_filter = 1 if PMG::Utils::update_local_spamassassin_channels(0);
 

> +    $restart_filter ||= $res;
>  };
>  syslog('err', "$@") if $@;
>