public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] quarantine: ticket: use raw pmail for ticket assembly
Date: Tue, 26 Sep 2023 09:06:23 +0200	[thread overview]
Message-ID: <0167b710-641a-474b-bce9-92723b651f8f@proxmox.com> (raw)
In-Reply-To: <20230913162046.12637-1-s.ivanov@proxmox.com>

Am 13/09/2023 um 18:20 schrieb Stoiko Ivanov:
> currently the quarantine report does not work if the recipient has
> some encodable characters in their local part - e.g.
> 'some&other@domain.example'
> 
> when clicking on the links on the report the user gets logged in
> however their quarantine list is empty (the call to
> /api2/json/quarantine/spamusers returns 403)
> 
> With this patch the ticket (thus also the username remains
> 'some&other@domain.example' instead of 'some&amp;other@domain.example'
> and the listing works as expected
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Tested this quickly here in my test-setup - but would really need some
> feedback on potential pitfalls, as this is authentication-related code...
> 
>  src/PMG/CLI/pmgqm.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, took the liberty to reword/add a bit to the commit message, thanks!




      parent reply	other threads:[~2023-09-26  7:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 16:20 [pmg-devel] " Stoiko Ivanov
2023-09-22  9:37 ` Stoiko Ivanov
2023-09-26  7:06 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0167b710-641a-474b-bce9-92723b651f8f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal