[pdm-devel] appled: [PATCH pve-network v4 1/6] sdn: api: return null for rollback / lock endpoints

From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] appled: [PATCH pve-network v4 1/6] sdn: api: return null for rollback / lock endpoints
Date: Thu, 4 Sep 2025 14:31:38 +0200	[thread overview]
Message-ID: <t4mdhf6a3xgladqtzablkffa5egips47s6fq3y4ateh6q5w5db@7gnxfglgjfdw> (raw)
In-Reply-To: <20250904081900.12655-5-s.hanreich@proxmox.com>

applied all pve-network patches, thanks

On Thu, Sep 04, 2025 at 10:18:29AM +0200, Stefan Hanreich wrote:
> lock_sdn_config can return a boolean value, which will then in turn
> get returned as data from the API calls. Since we hint type null here,
> this leads to problems with the pve-api-client in rust. Fix the return
> value for this API call by adding an explicit return statement.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/API2/Network/SDN.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/PVE/API2/Network/SDN.pm b/src/PVE/API2/Network/SDN.pm
> index af00b1a..88b229c 100644
> --- a/src/PVE/API2/Network/SDN.pm
> +++ b/src/PVE/API2/Network/SDN.pm
> @@ -192,6 +192,8 @@ __PACKAGE__->register_method({
>                  $param->{'lock-token'},
>              );
>          }
> +
> +        return;
>      },
>  });
>  
> @@ -247,6 +249,8 @@ __PACKAGE__->register_method({
>          PVE::Network::SDN::lock_sdn_config(
>              $rollback, "could not rollback SDN configuration", $lock_token,
>          );
> +
> +        return;
>      },
>  });
>  
> -- 
> 2.47.2


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel