Re: [PATCH datacenter-manager] ui: adjust testing description

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Dominik Rusovac <d.rusovac@proxmox.com> writes:

> Describe how to use trunk server for testing.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>  ui/README.md | 18 +++++-------------
>  1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/ui/README.md b/ui/README.md
> index f083ea5..05d8ae6 100644
> --- a/ui/README.md
> +++ b/ui/README.md
> @@ -2,20 +2,12 @@
>  
>  # Testing
>  
> -1.) start datacenter manager
> +Assuming pdm is running on, for example, 172.16.254.1:8443.

I would say this is a missing an "at" before the address.

> -sudo ./target/debug/proxmox-datacenter-privileged-api
> -sudo -u www-data ./target/debug/proxmox-datacenter-api 
> +To test on http://localhost:8080, use:
>  
> -2.) either: start local trunk server
> +    trunk serve --proxy-backend=https://172.16.254.1:8443/api2/ --proxy-insecure
>  
> - trunk serve --proxy-backend=https://localhost:8443/api2/ --proxy-insecure
> +To test elsewhere, say https://dev:8080/, generate a cert to obtain `api.key` and `api.pem`, and use:
>  
> - then test with url: http://localhost:8080
> -
> -2.) or: copy files into pdm js folder:
> -
> -    make all
> -    make install
> -
> -And test with url https://localhost:8443
> +    trunk serve --address 0.0.0.0 --serve-base / --proxy-backend https://172.16.254.1:8443/api2/ --public-url https://dev:8080/ --proxy-insecure --tls-key-path api.key --tls-cert-path api.pem

This is an improvement compared to the current state.

As a side note, I would like to see an introduction with a high-level
description of the process, something along the lines of "For testing
changes in the web UI, we recommend to run a Datacenter Manager daemon,
which can be done on a virtual machine or an existing instance, build
the web UI with your changes and proxy the API calls to the previously
mentioned daemon, this can be done via...".

-- 
Maximiliano