From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] connection: add a logging to unknown errors
Date: Fri, 24 Oct 2025 14:57:19 +0200 [thread overview]
Message-ID: <s8oikg4v4nk.fsf@proxmox.com> (raw)
In-Reply-To: <20251024112615.1208028-2-m.sandoval@proxmox.com> (Maximiliano Sandoval's message of "Fri, 24 Oct 2025 13:26:02 +0200")
Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> server/src/connection.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/server/src/connection.rs b/server/src/connection.rs
> index cf8f788..41469a5 100644
> --- a/server/src/connection.rs
> +++ b/server/src/connection.rs
> @@ -760,6 +760,8 @@ macro_rules! try_request {
> "failed to perform API request: timed out",
> ))
> } else {
> + let path = $path_and_query;
> + log::error!("Unknown client error out on request {path} - {err:?}");
I'll send v2, there is no err in this branch.
> Err(proxmox_client::Error::Other(
> "failed to perform API request: unknown error",
> ))
--
Maximiliano
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-10-24 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 11:26 [pdm-devel] [PATCH proxmox-datacenter-manager 1/2] connection: log which API request failed Maximiliano Sandoval
2025-10-24 11:26 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/2] connection: add a logging to unknown errors Maximiliano Sandoval
2025-10-24 12:57 ` Maximiliano Sandoval [this message]
2025-10-24 13:01 ` [pdm-devel] superseded: [PATCH proxmox-datacenter-manager 1/2] connection: log which API request failed Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oikg4v4nk.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox