Re: [pdm-devel] [PATCH proxmox-api-types 3/4] pve-api-types: Use &str instead of format!

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

Please don't patch code which, as indicated, is *generated*.
Patch the generator instead.
This change will be reverted automatically every time the code gets updated.

On Mon, Jan 13, 2025 at 01:12:23PM +0100, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  pve-api-types/src/generated/code.rs | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/pve-api-types/src/generated/code.rs b/pve-api-types/src/generated/code.rs
> index dc17cd9..3da259b 100644
> --- a/pve-api-types/src/generated/code.rs
> +++ b/pve-api-types/src/generated/code.rs
> @@ -764,8 +764,8 @@ where
>  
>      /// Authentication domain index.
>      async fn list_domains(&self) -> Result<Vec<ListRealm>, Error> {
> -        let url = format!("/api2/extjs/access/domains");
> -        Ok(self.0.get(&url).await?.expect_json()?.data)
> +        let url = "/api2/extjs/access/domains";
> +        Ok(self.0.get(url).await?.expect_json()?.data)
>      }
>  
>      /// LXC container index (per node).
> @@ -788,8 +788,8 @@ where
>  
>      /// Cluster node index.
>      async fn list_nodes(&self) -> Result<Vec<ClusterNodeIndexResponse>, Error> {
> -        let url = format!("/api2/extjs/nodes");
> -        Ok(self.0.get(&url).await?.expect_json()?.data)
> +        let url = "/api2/extjs/nodes";
> +        Ok(self.0.get(url).await?.expect_json()?.data)
>      }
>  
>      /// Virtual machine index (per node).
> @@ -1010,7 +1010,7 @@ where
>      /// API version details, including some parts of the global datacenter
>      /// config.
>      async fn version(&self) -> Result<VersionResponse, Error> {
> -        let url = format!("/api2/extjs/version");
> -        Ok(self.0.get(&url).await?.expect_json()?.data)
> +        let url = "/api2/extjs/version";
> +        Ok(self.0.get(url).await?.expect_json()?.data)
>      }
>  }
> -- 
> 2.39.5


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel