From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C6C6C1FF15E for ; Tue, 14 Jan 2025 14:22:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E94E1658D; Tue, 14 Jan 2025 14:22:08 +0100 (CET) Date: Tue, 14 Jan 2025 14:21:43 +0100 From: Wolfgang Bumiller To: Maximiliano Sandoval Message-ID: References: <20250113121224.302766-1-m.sandoval@proxmox.com> <20250113121224.302766-3-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250113121224.302766-3-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [code.rs] Subject: Re: [pdm-devel] [PATCH proxmox-api-types 3/4] pve-api-types: Use &str instead of format! X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Please don't patch code which, as indicated, is *generated*. Patch the generator instead. This change will be reverted automatically every time the code gets updated. On Mon, Jan 13, 2025 at 01:12:23PM +0100, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > pve-api-types/src/generated/code.rs | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/pve-api-types/src/generated/code.rs b/pve-api-types/src/generated/code.rs > index dc17cd9..3da259b 100644 > --- a/pve-api-types/src/generated/code.rs > +++ b/pve-api-types/src/generated/code.rs > @@ -764,8 +764,8 @@ where > > /// Authentication domain index. > async fn list_domains(&self) -> Result, Error> { > - let url = format!("/api2/extjs/access/domains"); > - Ok(self.0.get(&url).await?.expect_json()?.data) > + let url = "/api2/extjs/access/domains"; > + Ok(self.0.get(url).await?.expect_json()?.data) > } > > /// LXC container index (per node). > @@ -788,8 +788,8 @@ where > > /// Cluster node index. > async fn list_nodes(&self) -> Result, Error> { > - let url = format!("/api2/extjs/nodes"); > - Ok(self.0.get(&url).await?.expect_json()?.data) > + let url = "/api2/extjs/nodes"; > + Ok(self.0.get(url).await?.expect_json()?.data) > } > > /// Virtual machine index (per node). > @@ -1010,7 +1010,7 @@ where > /// API version details, including some parts of the global datacenter > /// config. > async fn version(&self) -> Result { > - let url = format!("/api2/extjs/version"); > - Ok(self.0.get(&url).await?.expect_json()?.data) > + let url = "/api2/extjs/version"; > + Ok(self.0.get(url).await?.expect_json()?.data) > } > } > -- > 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel