[pdm-devel] [PATCH proxmox] Schema2Rust: handle missing parameters->properties

[pdm-devel] [PATCH proxmox] Schema2Rust: handle missing parameters->properties

[Hannes Laimer]

We crashed if we encountered
```
    parameters => {
        additionalProperties => 0,
    },
```
almost all endpoint specify this explicitly, so
```
    parameters => {
        additionalProperties => 0,
        properties => {},
    },
```
I found at least these
- `/cluster/firewall/options`
- `/cluster/firewall/macros`
to be exceptions to this, there may be more.

Our api-macro does also not need this to be specified explicitly,
therefore we have the generator infer `properties => {}` in case it is
not specified explicitly, i.e. it is missing.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 pve-api-types/generator-lib/Schema2Rust.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pve-api-types/generator-lib/Schema2Rust.pm b/pve-api-types/generator-lib/Schema2Rust.pm
index 0f3efc0a..7d600ae7 100644
--- a/pve-api-types/generator-lib/Schema2Rust.pm
+++ b/pve-api-types/generator-lib/Schema2Rust.pm
@@ -1561,13 +1561,13 @@ my sub method_parameters : prototype($$$$$) {
 
     my $url_params = url_parameters($api_url);
 
-    my $parameters = $api_method->{parameters};
+    my $parameters = $api_method->{parameters} // {};
 
     #print "URL PARAMETERS: ".join(', ', $url_params->@*)."\n";
 
     # Clone to avoid modifying the duplicate.
     $parameters = { $parameters->%* };
-    my $properties = { $parameters->{properties}->%* };
+    my $properties = { ($parameters->{properties} // {})->%* };
     $parameters->{properties} = $properties;
 
     # Handle URL parameter types. These should only be strings or integers.
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH proxmox] Schema2Rust: handle missing parameters->properties

[Wolfgang Bumiller]

applied, thanks

On Fri, Sep 26, 2025 at 02:59:40PM +0200, Hannes Laimer wrote:
> We crashed if we encountered
> ```
>     parameters => {
>         additionalProperties => 0,
>     },
> ```
> almost all endpoint specify this explicitly, so
> ```
>     parameters => {
>         additionalProperties => 0,
>         properties => {},
>     },
> ```
> I found at least these
> - `/cluster/firewall/options`
> - `/cluster/firewall/macros`
> to be exceptions to this, there may be more.
> 
> Our api-macro does also not need this to be specified explicitly,
> therefore we have the generator infer `properties => {}` in case it is
> not specified explicitly, i.e. it is missing.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  pve-api-types/generator-lib/Schema2Rust.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pve-api-types/generator-lib/Schema2Rust.pm b/pve-api-types/generator-lib/Schema2Rust.pm
> index 0f3efc0a..7d600ae7 100644
> --- a/pve-api-types/generator-lib/Schema2Rust.pm
> +++ b/pve-api-types/generator-lib/Schema2Rust.pm
> @@ -1561,13 +1561,13 @@ my sub method_parameters : prototype($$$$$) {
>  
>      my $url_params = url_parameters($api_url);
>  
> -    my $parameters = $api_method->{parameters};
> +    my $parameters = $api_method->{parameters} // {};
>  
>      #print "URL PARAMETERS: ".join(', ', $url_params->@*)."\n";
>  
>      # Clone to avoid modifying the duplicate.
>      $parameters = { $parameters->%* };
> -    my $properties = { $parameters->{properties}->%* };
> +    my $properties = { ($parameters->{properties} // {})->%* };
>      $parameters->{properties} = $properties;
>  
>      # Handle URL parameter types. These should only be strings or integers.
> -- 
> 2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel