public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] applied-series: [PATCH proxmox{, -datacenter-manager} v2 0/4] generate Vec's for string-lists
Date: Tue, 28 Oct 2025 14:30:41 +0100	[thread overview]
Message-ID: <ewqmzlr5gm4wxtg3qj4zjjh53egcekpecpkboav6t4ztmqqgsz@dxakiewmwvk7> (raw)
In-Reply-To: <20251024144250.145205-1-h.laimer@proxmox.com>

applied the series with some followups (see reply to patch 1/3), thanks

On Fri, Oct 24, 2025 at 04:42:46PM +0200, Hannes Laimer wrote:
> PVE does accept actual arrays[1] as input to fields with a `-list` format.
> This updates the generator so it produces a Vec if it is a parameter,
> not for return values.
> 
> I did not find endpoint that directly share the same format for
> parameters and return value. Update endpoint also include a
> `delete`-field and those were the only ones that had really similar
> input and output formats. So deduplication in the generate _should_ not be
> a problem here.
> 
> This required some small changes to pdm. Context for those is in the
> commit itself.
> 
> v2, thanks @Wolfgang:
>  - fix/improve perl code
>  - add `is_option_vec`-flag, like we do for `is_string_list`
> 
> 
> [1] pve-common 69d9edcc ("section config: implement array support")
> 
> 
> proxmox:
> 
> Hannes Laimer (3):
>   pve-api-types: schema2rust: generate arrays for types with format
>     `-list`
>   pve-api-types: add regex for both storage- and bridge-pair
>   pve-api-types: regenerate
> 
>  pve-api-types/generate.pl                  |  11 +-
>  pve-api-types/generator-lib/Schema2Rust.pm |  41 ++-
>  pve-api-types/src/generated/code.rs        |   2 +-
>  pve-api-types/src/generated/types.rs       | 335 +++++++++++----------
>  pve-api-types/src/types/verifiers.rs       |  10 -
>  5 files changed, 220 insertions(+), 179 deletions(-)
> 
> 
> proxmox-datacenter-manager:
> 
> Hannes Laimer (1):
>   server: use types indead of string for migration parameters
> 
>  server/src/api/pve/lxc.rs  | 133 ++++++++----------------------------
>  server/src/api/pve/qemu.rs | 135 ++++++++-----------------------------
>  2 files changed, 56 insertions(+), 212 deletions(-)
> 
> 
> Summary over all repositories:
>   7 files changed, 276 insertions(+), 391 deletions(-)
> 
> -- 
> Generated by git-murpp 0.8.1


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      parent reply	other threads:[~2025-10-28 13:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 14:42 [pdm-devel] " Hannes Laimer
2025-10-24 14:42 ` [pdm-devel] [PATCH proxmox v2 1/3] pve-api-types: schema2rust: generate arrays for types with format `-list` Hannes Laimer
2025-10-28 13:29   ` Wolfgang Bumiller
2025-10-24 14:42 ` [pdm-devel] [PATCH proxmox v2 2/3] pve-api-types: add regex for both storage- and bridge-pair Hannes Laimer
2025-10-24 14:42 ` [pdm-devel] [PATCH proxmox v2 3/3] pve-api-types: regenerate Hannes Laimer
2025-10-24 14:42 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 1/1] server: use types indead of string for migration parameters Hannes Laimer
2025-10-28 13:30 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ewqmzlr5gm4wxtg3qj4zjjh53egcekpecpkboav6t4ztmqqgsz@dxakiewmwvk7 \
    --to=w.bumiller@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal