Re: [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema

[Samuel Rufinatscha <s.rufinatscha@proxmox.com>]

On 5/28/26 11:25 AM, Stefan Hanreich wrote:
> Otherwise, setting those properties causes issues on deserialization,
> since they're deserialized as additional properties (= String), which
> causes a '400 Bad Request' when trying to retrieve the answers via the
> PDM UI or the automated installer ISO.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>   proxmox-installer-types/src/answer.rs | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
> index 9c6317ae..27abd9ae 100644
> --- a/proxmox-installer-types/src/answer.rs
> +++ b/proxmox-installer-types/src/answer.rs
> @@ -508,6 +508,13 @@ impl ApiType for FilesystemOptions {
>       const API_SCHEMA: Schema = ObjectSchema::new(
>           "Filesystem-specific options to set on the root disk.",
>           &[
> +            (
> +                "arc_max",
> +                true,
> +                &IntegerSchema::new("Maximum ARC size that ZFS should use, in MiB")
> +                    .minimum(64)
> +                    .schema(),
> +            ),
>               (
>                   "ashift",
>                   true,
> @@ -517,6 +524,15 @@ impl ApiType for FilesystemOptions {
>                       .default(12)
>                       .schema(),
>               ),
> +            (
> +                "copies",
> +                true,
> +                &IntegerSchema::new("`copies` value to create the zpool with.")
> +                    .minimum(1)
> +                    .maximum(3)
> +                    .default(1)
> +                    .schema(),
> +            ),
>               ("filesystem", false, &Filesystem::API_SCHEMA),
>               (
>                   "hdsize",
> @@ -548,6 +564,15 @@ impl ApiType for FilesystemOptions {
>                       .minimum(0.)
>                       .schema(),
>               ),
> +            (
> +                "minfree",
> +                true,
> +                &NumberSchema::new(
> +                    "Minimum amount of free space that should be left in the LVM volume group.",
> +                )
> +                .minimum(0.)
> +                .schema(),
> +            ),
>               (
>                   "swapsize",
>                   true,

Tested - the patch fixes the issue.

Thanks for this super fast patch!

Tested-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>