From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema
Date: Thu, 28 May 2026 11:25:14 +0200 [thread overview]
Message-ID: <20260528092516.103885-1-s.hanreich@proxmox.com> (raw)
Otherwise, setting those properties causes issues on deserialization,
since they're deserialized as additional properties (= String), which
causes a '400 Bad Request' when trying to retrieve the answers via the
PDM UI or the automated installer ISO.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-installer-types/src/answer.rs | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
index 9c6317ae..27abd9ae 100644
--- a/proxmox-installer-types/src/answer.rs
+++ b/proxmox-installer-types/src/answer.rs
@@ -508,6 +508,13 @@ impl ApiType for FilesystemOptions {
const API_SCHEMA: Schema = ObjectSchema::new(
"Filesystem-specific options to set on the root disk.",
&[
+ (
+ "arc_max",
+ true,
+ &IntegerSchema::new("Maximum ARC size that ZFS should use, in MiB")
+ .minimum(64)
+ .schema(),
+ ),
(
"ashift",
true,
@@ -517,6 +524,15 @@ impl ApiType for FilesystemOptions {
.default(12)
.schema(),
),
+ (
+ "copies",
+ true,
+ &IntegerSchema::new("`copies` value to create the zpool with.")
+ .minimum(1)
+ .maximum(3)
+ .default(1)
+ .schema(),
+ ),
("filesystem", false, &Filesystem::API_SCHEMA),
(
"hdsize",
@@ -548,6 +564,15 @@ impl ApiType for FilesystemOptions {
.minimum(0.)
.schema(),
),
+ (
+ "minfree",
+ true,
+ &NumberSchema::new(
+ "Minimum amount of free space that should be left in the LVM volume group.",
+ )
+ .minimum(0.)
+ .schema(),
+ ),
(
"swapsize",
true,
--
2.47.3
next reply other threads:[~2026-05-28 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 9:25 Stefan Hanreich [this message]
2026-05-28 9:45 ` [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema Samuel Rufinatscha
2026-05-28 11:00 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528092516.103885-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox