public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>, Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/3] fix #6901: allow non root users to access the EVPN dashboard
Date: Wed, 15 Oct 2025 17:26:00 +0200	[thread overview]
Message-ID: <e7aa83f0-89e7-4a01-ac32-24034780b8f9@proxmox.com> (raw)
In-Reply-To: <20251014150358.553238-1-s.shaji@proxmox.com>

We might want to to reimplement more granular permissions as well, while
we're at it. Guests have /remotes/<remote>/guest/<vmid> for instance to
allow setting permissions on a per-guest level.

Imo, nothing speaks against implementing permissions the same way as SDN
currently does, which would then be on PDM side:

/remote/<remote>/sdn/zones/<zone>
/remote/<remote>/sdn/zones/<zone>/<vnet>
/remote/<remote>/sdn/controllers/<controller>


On 10/14/25 5:03 PM, Shan Shaji wrote:
> When a non-root user tried to access the EVPN section, the API was
> returning a "403: permission check failed" error. To fix this, explicit
> permission checks have been added for the `/zones`, `/vnets`, and
> `/controllers` endpoints.
> 
> Now, every authenticated user can access these endpoints however, the user
> must have at least the Resource.Audit permission under `/resource`.
> Remotes are also filtered based on the user’s access. Lists will only be
> fetched from remotes for which the user has at least the
> `Resource.Audit` permission on `/remote/{remote_name}`.
> 
> Shan Shaji (3):
>   fix #6901: api: add explicit permission check for controllers list
>   fix #6901: api: add explicit permission check for vnets list
>   fix #6901: api: add explicit permission check for zones list
> 
>  server/src/api/sdn/controllers.rs | 30 ++++++++++++++++++++++++++----
>  server/src/api/sdn/vnets.rs       | 29 ++++++++++++++++++++++++++---
>  server/src/api/sdn/zones.rs       | 28 +++++++++++++++++++++++++---
>  3 files changed, 77 insertions(+), 10 deletions(-)
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

  parent reply	other threads:[~2025-10-15 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 15:03 Shan Shaji
2025-10-14 15:03 ` [pdm-devel] [PATCH datacenter-manager 1/3] fix #6901: api: add explicit permission check for controllers list Shan Shaji
2025-10-14 15:03 ` [pdm-devel] [PATCH datacenter-manager 2/3] fix #6901: api: add explicit permission check for vnets list Shan Shaji
2025-10-15 15:20   ` Stefan Hanreich
2025-10-16  8:12     ` Shannon Sterz
2025-10-16  9:24       ` Stefan Hanreich
2025-10-17 11:45     ` Shan Shaji
2025-10-17 13:05       ` Shan Shaji
2025-10-14 15:03 ` [pdm-devel] [PATCH datacenter-manager 3/3] fix #6901: api: add explicit permission check for zones list Shan Shaji
2025-10-15 15:26 ` Stefan Hanreich [this message]
2025-10-17 11:44   ` [pdm-devel] [PATCH datacenter-manager 0/3] fix #6901: allow non root users to access the EVPN dashboard Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7aa83f0-89e7-4a01-ac32-24034780b8f9@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal