From: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager] fix #7120: remote updates: drop vanished nodes/remotes from cache file
Date: Thu, 8 Jan 2026 15:38:49 +0100 [thread overview]
Message-ID: <e1fd6167-a66d-418e-aa09-9750a8180a34@proxmox.com> (raw)
In-Reply-To: <20260108130649.210778-1-l.wagner@proxmox.com>
On 1/8/26 2:06 PM, Lukas Wagner wrote:
> This commits makes sure that vanished remotes and remote cluster nodes
> are dropped from the remote updates cache file. This happens whenever
> the cache file is fully refreshed, either by the periodic update task,
> or by pressing "Refresh All" in the UI.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> server/src/remote_updates.rs | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/server/src/remote_updates.rs b/server/src/remote_updates.rs
> index e772eef5..0490d28e 100644
> --- a/server/src/remote_updates.rs
> +++ b/server/src/remote_updates.rs
> @@ -214,6 +214,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec<Remote>) -> Result<(), Er
>
> let mut content = get_cached_summary_or_default()?;
>
> + // Clean out any remotes that might have been removed from the remote config in the meanwhile.
> + content
> + .remotes
> + .retain(|remote, _| fetch_results.remote_results.contains_key(remote));
> +
> for (remote_name, result) in fetch_results.remote_results {
> let entry = content
> .remotes
> @@ -234,6 +239,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec<Remote>) -> Result<(), Er
> Ok(remote_result) => {
> entry.status = RemoteUpdateStatus::Success;
>
> + // Clean out any nodes that might have been removed from the cluster in the meanwhile.
> + entry
> + .nodes
> + .retain(|name, _| remote_result.node_results.contains_key(name));
> +
> for (node_name, node_result) in remote_result.node_results {
> match node_result {
> Ok(NodeResults { data, .. }) => {
Patch looks good to me! I could reproduce the issue and can confirm
the patch works. After the patch,
/var/cache/proxmox-datacenter-manager/remote-updates.json no
longer shows the removed remote when running "Refresh All".
Reviewed-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
Tested-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2026-01-08 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 13:06 Lukas Wagner
2026-01-08 14:38 ` Samuel Rufinatscha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fd6167-a66d-418e-aa09-9750a8180a34@proxmox.com \
--to=s.rufinatscha@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox