From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>,
pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager] ui: auto-installer: mark regenerating auto installer tokens as dangerous
Date: Thu, 28 May 2026 12:26:47 +0200 [thread overview]
Message-ID: <ba0194ac-2f76-48b6-9447-b10a8408e8a8@proxmox.com> (raw)
In-Reply-To: <DIU8239DLNU1.IOKKT4H0FK8D@proxmox.com>
Am 28.05.26 um 12:01 schrieb Lukas Wagner:
> On Thu May 28, 2026 at 11:54 AM CEST, Thomas Lamprecht wrote:
>> IMO a bit borderline, as this is not like a classic API token where this
>> causes active service disruption.
> ack, FWIW, I checked what we do for classic API tokens, and while it's
> of course not the exact same thing, it seemed similar enough to use the
> same semantics here.
Actually I went back and forth a bit on exactly those yesterday, less because
of impact but more as each such sets basically a precedent ^^ But ultimately
decided that it's probably fine to err on the side of caution, especially on
removals and also with the not so big UI/UX impact here; that's why it's
also fine here.
So all good, just wanted to give slightly more context of my thoughts here.
And btw. my trigger for changing the confirm prompt in the first place was
the flashy red error icon that sprung into me when opening the "apply pending"
subscription prompt the first time after getting some distance from testing it
and me then thinking "wait, did I press a delete button".
next prev parent reply other threads:[~2026-05-28 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 9:26 [PATCH datacenter-manager] ui: auto-installer: mark regenerating auto installer tokens as dangerous Shannon Sterz
2026-05-28 9:44 ` applied: " Lukas Wagner
2026-05-28 9:54 ` Thomas Lamprecht
2026-05-28 10:02 ` Lukas Wagner
2026-05-28 10:26 ` Thomas Lamprecht [this message]
2026-05-28 10:04 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0194ac-2f76-48b6-9447-b10a8408e8a8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox