public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
	"Shannon Sterz" <s.sterz@proxmox.com>,
	<pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager] ui: auto-installer: mark regenerating auto installer tokens as dangerous
Date: Thu, 28 May 2026 12:02:13 +0200	[thread overview]
Message-ID: <DIU8239DLNU1.IOKKT4H0FK8D@proxmox.com> (raw)
In-Reply-To: <f2d89fcf-c9dc-4421-a2b2-80da26a88a47@proxmox.com>

On Thu May 28, 2026 at 11:54 AM CEST, Thomas Lamprecht wrote:
> IMO a bit borderline, as this is not like a classic API token where this
> causes active service disruption.

ack, FWIW, I checked what we do for classic API tokens, and while it's
of course not the exact same thing, it seemed similar enough to use the
same semantics here.

> OTOH. setting that flag hasn't that big of an impact and doesn't really
> hurt either, so fine. I'd just avoid using it for everything that can be
> framed as destructive, as most things with a confirmation prompts might be,
> as then it looses the punch a bit (or could again just be the default).
> But when implementing these yesterday I also could not come up with a
> definitive rule that always holds, so certainly not a clear cut - just
> wanted to avoid that we use this to liberally now - as said, here it was
> OK to do (except the short missing rationale).

I'll make sure to ask for a more detailed rationale in the commit
message next time, or add one myself if done easily enough!





  reply	other threads:[~2026-05-28 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28  9:26 [PATCH datacenter-manager] ui: auto-installer: mark regenerating auto installer tokens as dangerous Shannon Sterz
2026-05-28  9:44 ` applied: " Lukas Wagner
2026-05-28  9:54 ` Thomas Lamprecht
2026-05-28 10:02   ` Lukas Wagner [this message]
2026-05-28 10:26     ` Thomas Lamprecht
2026-05-28 10:04   ` Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIU8239DLNU1.IOKKT4H0FK8D@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal