Re: [pdm-devel] [PATCH yew-comp 2/2] token_panel: implement a token panel

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.10.25 um 17:29 schrieb Shannon Sterz:
> imo the proper solution however is to use the new clipboard api that is
> now in stable web-sys [1,2]. fabian packaged a new web-sys version this
> week, so i'd adapt to it unless someone objects to that.

Sounds good to me.

> note that `execCommand` used by copy_to_clipboard is
> deprecated [2].
> 
> [1]: https://docs.rs/web-sys/0.3.76/web_sys/struct.Clipboard.html
> [2]: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText
> [3]: https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand
> 
>> Btw. I know this mirrors the original and I added the copy button there,
>> but nowadays I'd prefer having a icon-only+tooltip button to the right of
>> the input field for both fields.
> makes sense, i can look into that while i'm at it. but imo, we should
> come up with a more consistent way of treating buttons with icons in
> general. most buttons in pdm don't use any icons at all.

FWIW, If there's a potential icon with clear meaning I always favor having
them, it ads additional visual distinction that helps UX.

But I do not think that what I meant here needs us to rethink the overall
approach, this is something more specific, especially as it'd be icon-only.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel