Re: [PATCH datacenter-manager v2] fix #7120: remote updates: drop vanished nodes/remotes from cache file

[Lukas Sichert <l.sichert@proxmox.com>]

I was able to reproduce the Bug by
-removing a configured cluster from the PDM,
-deleting the cluster,
-changing the node names,
-setting up a new cluster with the same name
-adding the cluster again in PDM using the same Remote ID as before.
Now, both the old and new node names appear.
Also by manually altering the cache file and just renaming one of the
nodes, one can force the original name and the new name to show up in
the GUI.
This was tested with and without [0].

After applying this commit on top of [0], I could not reproduce the bug.

The changes look good to me.


Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Lukas Sichert <l.sichert@proxmox.com>


[0]:
https://lore.proxmox.com/all/20260206094304.117465-1-l.wagner@proxmox.com/T/#u

On 2026-02-06 11:18, Lukas Wagner wrote:
> This commits makes sure that vanished remotes and remote cluster nodes
> are dropped from the remote updates cache file. This happens whenever
> the cache file is fully refreshed, either by the periodic update task,
> or by pressing "Refresh All" in the UI.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>     Changes since v1:
>       - rebased on top of the parallel fetcher changes [0] - these need to
>         be applied first!
>     
>     [0]: https://lore.proxmox.com/all/20260206094304.117465-1-l.wagner@proxmox.com/T/#u
> 
>  server/src/remote_updates.rs | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/server/src/remote_updates.rs b/server/src/remote_updates.rs
> index 2762001e..7aaacc46 100644
> --- a/server/src/remote_updates.rs
> +++ b/server/src/remote_updates.rs
> @@ -214,6 +214,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec<Remote>) -> Result<(), Er
>  
>      let mut content = get_cached_summary_or_default()?;
>  
> +    // Clean out any remotes that might have been removed from the remote config in the meanwhile.
> +    content
> +        .remotes
> +        .retain(|remote, _| fetch_response.iter().any(|r| r.remote() == remote));
> +
>      for remote_response in fetch_response {
>          let remote_name = remote_response.remote().to_string();
>  
> @@ -228,6 +233,11 @@ pub async fn refresh_update_summary_cache(remotes: Vec<Remote>) -> Result<(), Er
>  
>          match remote_response.nodes() {
>              Ok(node_responses) => {
> +                // Clean out any nodes that might have been removed from the cluster in the meanwhile.
> +                entry
> +                    .nodes
> +                    .retain(|name, _| node_responses.iter().any(|n| n.node_name() == name));
> +
>                  entry.status = RemoteUpdateStatus::Success;
>  
>                  for node_response in node_responses {