public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pdm-devel] [RFC pdm v2] ui: make layout more consistent using new ContentSpacer widget
Date: Wed, 15 Jan 2025 16:48:41 +0100	[thread overview]
Message-ID: <af497b3b-2862-4ed7-9966-d356bb77512e@proxmox.com> (raw)
In-Reply-To: <20250110125023.190875-1-dietmar@proxmox.com>

Am 10.01.25 um 13:50 schrieb Dietmar Maurer:
> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
> ---
> 
>  Changhes in v2:
>  - use box shadows instead of border
>  - use ContentSpacer for dashboard
>  - use ContentSpacer for PveRemote
> 
>  ui/css/crisp-yew-style.scss            | 12 ++++
>  ui/css/desktop-yew-style.scss          | 11 +++
>  ui/css/pdm.scss                        | 26 ++++++-
>  ui/src/administration/mod.rs           | 28 ++++++--
>  ui/src/certificates.rs                 | 30 ++++++--
>  ui/src/configuration/mod.rs            | 25 ++++---
>  ui/src/configuration/other/mod.rs      |  9 ++-
>  ui/src/configuration/other/webauthn.rs |  1 -
>  ui/src/dashboard/mod.rs                | 17 +++--
>  ui/src/main_menu.rs                    | 22 +++---
>  ui/src/pve/mod.rs                      |  7 +-
>  ui/src/widget/content_spacer.rs        | 99 ++++++++++++++++++++++++++
>  ui/src/widget/mod.rs                   |  3 +
>  13 files changed, 242 insertions(+), 48 deletions(-)
>  create mode 100644 ui/src/widget/content_spacer.rs

This was seemingly applied now by yourself? I saw no review on the list, did I
miss it?

The configuration, syslog, ... panels look quite odd now, it's a bit hard to
tell if that is wanted as there is no commit message describing the whats and
whys..

So I'd revert this again?


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-01-15 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 12:50 Dietmar Maurer
2025-01-15 15:48 ` Thomas Lamprecht [this message]
2025-01-15 17:38   ` Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af497b3b-2862-4ed7-9966-d356bb77512e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal