public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [RFC pdm v2] ui: make layout more consistent using new ContentSpacer widget
Date: Wed, 15 Jan 2025 18:38:01 +0100 (CET)	[thread overview]
Message-ID: <1735555146.4594.1736962681642@webmail.proxmox.com> (raw)
In-Reply-To: <af497b3b-2862-4ed7-9966-d356bb77512e@proxmox.com>

> This was seemingly applied now by yourself? I saw no review on the list, did I
> miss it?

Applied by accident, sorry.

> The configuration, syslog, ... panels look quite odd now, it's a bit hard to
> tell if that is wanted as there is no commit message describing the whats and whys..

IMHO layout it is better than before, because it has more consistent spacing (as written in the commit message). All major pages use the same style now.

Also, IT only affects the new "Desktop" style. ("Crisp" theme should be mainly unaffected).

Lets talk tomorrow in the office. Maybe we can find a improvement for syslog like panels. If not, we can still revert.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      reply	other threads:[~2025-01-15 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 12:50 Dietmar Maurer
2025-01-15 15:48 ` Thomas Lamprecht
2025-01-15 17:38   ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1735555146.4594.1736962681642@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal