public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v5 6/6] fake remote: clippy fixes
Date: Thu, 15 May 2025 09:05:29 +0200	[thread overview]
Message-ID: <ab7aaf4b-97a0-4516-b97e-fd69fcb09118@proxmox.com> (raw)
In-Reply-To: <20250512114144.118545-7-l.wagner@proxmox.com>


Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 5/12/25 13:41, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>      Added in v3
> 
>   server/src/test_support/fake_remote.rs | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
> index ae0f0af1..27ba7c5c 100644
> --- a/server/src/test_support/fake_remote.rs
> +++ b/server/src/test_support/fake_remote.rs
> @@ -1,4 +1,4 @@
> -use std::{collections::HashMap, sync::Arc, time::Duration};
> +use std::{sync::Arc, time::Duration};
>   
>   use anyhow::{bail, Error};
>   use serde::Deserialize;
> @@ -129,7 +129,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
>           let mut vmid = 100;
>   
>           for _ in 0..self.nr_of_vms {
> -            vmid = vmid + 1;
> +            vmid += 1;
>               result.push(ClusterResource {
>                   cgroup_mode: None,
>                   content: None,
> @@ -162,7 +162,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
>           }
>   
>           for _ in 0..self.nr_of_cts {
> -            vmid = vmid + 1;
> +            vmid += 1;
>               result.push(ClusterResource {
>                   cgroup_mode: None,
>                   content: None,
> @@ -354,7 +354,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
>       async fn list_nodes(&self) -> Result<Vec<ClusterNodeIndexResponse>, proxmox_client::Error> {
>           tokio::time::sleep(Duration::from_millis(self.api_delay_ms as u64)).await;
>           Ok((0..self.nr_of_nodes)
> -            .into_iter()
>               .map(|i| ClusterNodeIndexResponse {
>                   node: format!("pve-{i}"),
>                   cpu: None,
> @@ -411,7 +410,6 @@ impl pve_api_types::client::PveClient for FakePveClient {
>           let number_of_tasks = limit.min(number_of_tasks as u64);
>   
>           Ok((0..number_of_tasks)
> -            .into_iter()
>               .map(|i| make_task(now - i as i64 * NEW_TASK_EVERY * 60))
>               .collect())
>       }



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      reply	other threads:[~2025-05-15  7:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 11:41 [pdm-devel] [PATCH proxmox-datacenter-manager v5 0/6] remote task cache fetching task / better cache backend Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 1/6] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-05-14 14:08   ` Dominik Csapak
2025-07-01 10:02     ` Lukas Wagner
2025-07-03  8:05     ` Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 2/6] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-05-14 15:27   ` Dominik Csapak
2025-07-03  8:05     ` Lukas Wagner
2025-07-03 11:25       ` Dominik Csapak
2025-07-09 11:22       ` Lukas Wagner
2025-07-09 11:35         ` Dominik Csapak
2025-07-09 12:25           ` Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 3/6] remote tasks: improve locking for task archive iterator Lukas Wagner
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 4/6] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-05-15  6:56   ` Dominik Csapak
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 5/6] fake remote: make the fake_remote feature compile again Lukas Wagner
2025-05-15  6:55   ` Dominik Csapak
2025-05-12 11:41 ` [pdm-devel] [PATCH proxmox-datacenter-manager v5 6/6] fake remote: clippy fixes Lukas Wagner
2025-05-15  7:05   ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab7aaf4b-97a0-4516-b97e-fd69fcb09118@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal