Re: [PATCH datacenter-manager v2 0/2] improvements for ParallelFetcher

[Lukas Sichert <l.sichert@proxmox.com>]

The changes were reviewed and tested in a cluster consisting of two
PVE nodes and one PBS. The following features were considered for testing:

Update handling:
The update summary could be retrieved without issues.

Tasks:
The task log was displayed correctly.

Only for the cluster:
SDN:
A Simple Zone and an EVPN Zone were created.
Both zones and the EVPN Controller were displayed correctly.

Firewall:
Node firewall rules and datacenter firewall configuration were shown
correctly.

The tests were also repeated with one of the nodes offline, and
everything still worked as expected.

While reviewing the code, I noticed that the async fetchers currently
have no explicit timeouts. If one of the fetch operations blocks
indefinitely, it could stall the overall execution. Adding this in a
future commit would improve robustness.

Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Lukas Sichert <l.sichert@proxmox.com>

On 2/6/26 10:41, Lukas Wagner wrote:
> A couple of improvents for the parallel_fetcher module:
>   - inherit log context so that logging in worker tasks works
>   - response type improvements, better ergonomics for callers
>   - documentation
> 
> Changes since v2:
>   - Change type names from *Outcome to *Response
> 
> 
> proxmox-datacenter-manager:
> 
> Lukas Wagner (2):
>   parallel fetcher: improve result type ergonomics
>   parallel fetcher: add module documentation
> 
>  server/src/api/pve/firewall.rs                |  53 +--
>  server/src/api/sdn/controllers.rs             |  38 +-
>  server/src/api/sdn/vnets.rs                   |  35 +-
>  server/src/api/sdn/zones.rs                   |  35 +-
>  .../tasks/remote_tasks.rs                     |  33 +-
>  server/src/parallel_fetcher.rs                | 333 +++++++++++++-----
>  server/src/remote_updates.rs                  |  36 +-
>  7 files changed, 340 insertions(+), 223 deletions(-)
> 
> 
> Summary over all repositories:
>   7 files changed, 340 insertions(+), 223 deletions(-)
>