From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v5 00/10] refactor and partially fix #7371
Date: Mon, 05 Oct 2026 09:50:19 +0200 [thread overview]
Message-ID: <DLWQNXGDPTVI.420RCZ2EMV6W@proxmox.com> (raw)
In-Reply-To: <29f5eef5-1147-45ca-a921-8bb554278ac1@proxmox.com>
On Mon Oct 5, 2026 at 9:09 AM CEST, Dominik Csapak wrote:
> FYI: this version has a bug that the tags are shown double in the
> resource tree. (this could be a fixup or i can send
> a new version depending on the remaining review)
>
Please send a new version (possibly rebased on to of v2 of [0], if
needed), I'd go ahead and apply them after a final quick smoke test.
Code-wise the changes looked good already, and a quick skim of this
iteration also didn't raise any red flags.
>>
>> 0: https://lore.proxmox.com/pdm-devel/20261002135324.3147672-1-d.csapak@proxmox.com/T/#t
>>
next prev parent reply other threads:[~2026-10-05 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 14:13 [PATCH datacenter-manager v5 00/10] refactor and partially fix #7371 Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 01/10] lib: api types: add new ResourceView type and move accessors there Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 02/10] lib: api types: resource: add 'node' helper to ResourceView Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 03/10] lib: api types: add guest specific getter " Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 04/10] ui: pve: factor out the pve-manager version extraction Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 05/10] ui: renderer: use ResourceView for rendering Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 06/10] ui: pve: tree: reuse `PveResource` for `PveTreeNode` Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 07/10] ui: pve: show ha maintenance mode for nodes Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 08/10] ui: pve: node selector: show maintenance badge with node name Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 09/10] ui: pve: node selector: sort memory columns by usage not by memory size Dominik Csapak
2026-10-02 14:13 ` [PATCH datacenter-manager v5 10/10] ui: pve: node: show ha maintenance badge Dominik Csapak
2026-10-05 7:09 ` [PATCH datacenter-manager v5 00/10] refactor and partially fix #7371 Dominik Csapak
2026-10-05 7:50 ` Lukas Wagner [this message]
2026-10-05 11:01 ` superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLWQNXGDPTVI.420RCZ2EMV6W@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox