From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2737A1FF09C for ; Mon, 05 Oct 2026 09:50:24 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D0909213B9; Mon, 05 Oct 2026 09:50:23 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Mon, 05 Oct 2026 09:50:19 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v5 00/10] refactor and partially fix #7371 From: "Lukas Wagner" To: "Dominik Csapak" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20261002141448.3336388-1-d.csapak@proxmox.com> <29f5eef5-1147-45ca-a921-8bb554278ac1@proxmox.com> In-Reply-To: <29f5eef5-1147-45ca-a921-8bb554278ac1@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791186619954 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.359 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MVGPBN5FFVXLSKOXAHKLGT6KQYF26WJD X-Message-ID-Hash: MVGPBN5FFVXLSKOXAHKLGT6KQYF26WJD X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Oct 5, 2026 at 9:09 AM CEST, Dominik Csapak wrote: > FYI: this version has a bug that the tags are shown double in the=20 > resource tree. (this could be a fixup or i can send > a new version depending on the remaining review) > Please send a new version (possibly rebased on to of v2 of [0], if needed), I'd go ahead and apply them after a final quick smoke test. Code-wise the changes looked good already, and a quick skim of this iteration also didn't raise any red flags. >>=20 >> 0: https://lore.proxmox.com/pdm-devel/20261002135324.3147672-1-d.csapak@= proxmox.com/T/#t >>=20