public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [RFC PATCH datacenter-manager 2/2] ui: pve: tree: size action column better
Date: Mon, 05 Oct 2026 09:43:10 +0200	[thread overview]
Message-ID: <DLWQIG0ZANGG.ZXLB11Y5HRKR@proxmox.com> (raw)
In-Reply-To: <20261002135324.3147672-2-d.csapak@proxmox.com>

On Fri Oct 2, 2026 at 3:50 PM CEST, Dominik Csapak wrote:
> instead of using a fixed pixel size. While the new expression looks ugly, that is the
> exact size needed to show all action columns in all density variants.
>
> Ideally we'd have a way to automatically size a column by it's content
> (in a buffered grid), but until we implement such a thing, this should
> be ok.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> meh, i don't like either the before nor the after. I have some ideas
> how we could make this work on the datatable side in a generic way, but
> this is rather involved, and i'm not sure if it's worth it to spend
> much time on it when we can do it like this.
>
>  ui/src/pve/tree.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/src/pve/tree.rs b/ui/src/pve/tree.rs
> index 2faa4349..6cac96fa 100644
> --- a/ui/src/pve/tree.rs
> +++ b/ui/src/pve/tree.rs
> @@ -645,7 +645,7 @@ fn columns(
>              })
>              .into(),
>          DataTableColumn::new(tr!("Actions"))
> -            .width("180px")
> +            .width("calc(4 * (20px + 2* var(--pwt-spacer-1)) + 2 * var(--pwt-spacer-2))")

Could be worth a comment IMO, until we have a nicer way to handle this
generically.

>              .render(move |entry: &PveTreeNode| {
>                  let (id, local_id, guest_info, node) = match entry {
>                      PveTreeNode::Lxc(r) => {





  reply	other threads:[~2026-10-05  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 13:50 [RFC PATCH datacenter-manager 1/2] ui: pve: tree: render guest tags directly after their name Dominik Csapak
2026-10-02 13:50 ` [RFC PATCH datacenter-manager 2/2] ui: pve: tree: size action column better Dominik Csapak
2026-10-05  7:43   ` Lukas Wagner [this message]
2026-10-05  7:39 ` [RFC PATCH datacenter-manager 1/2] ui: pve: tree: render guest tags directly after their name Lukas Wagner
2026-10-05 11:02 ` superseded: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLWQIG0ZANGG.ZXLB11Y5HRKR@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal