From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 499D91FF09C for ; Mon, 05 Oct 2026 09:43:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0911D213A5; Mon, 05 Oct 2026 09:43:14 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 05 Oct 2026 09:43:10 +0200 Message-Id: Subject: Re: [RFC PATCH datacenter-manager 2/2] ui: pve: tree: size action column better From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20261002135324.3147672-1-d.csapak@proxmox.com> <20261002135324.3147672-2-d.csapak@proxmox.com> In-Reply-To: <20261002135324.3147672-2-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791186190176 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.360 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5TMBJYB3PFUPVWXM5BVMU45GDBS3HYPO X-Message-ID-Hash: 5TMBJYB3PFUPVWXM5BVMU45GDBS3HYPO X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Oct 2, 2026 at 3:50 PM CEST, Dominik Csapak wrote: > instead of using a fixed pixel size. While the new expression looks ugly,= that is the > exact size needed to show all action columns in all density variants. > > Ideally we'd have a way to automatically size a column by it's content > (in a buffered grid), but until we implement such a thing, this should > be ok. > > Signed-off-by: Dominik Csapak > --- > meh, i don't like either the before nor the after. I have some ideas > how we could make this work on the datatable side in a generic way, but > this is rather involved, and i'm not sure if it's worth it to spend > much time on it when we can do it like this. > > ui/src/pve/tree.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/src/pve/tree.rs b/ui/src/pve/tree.rs > index 2faa4349..6cac96fa 100644 > --- a/ui/src/pve/tree.rs > +++ b/ui/src/pve/tree.rs > @@ -645,7 +645,7 @@ fn columns( > }) > .into(), > DataTableColumn::new(tr!("Actions")) > - .width("180px") > + .width("calc(4 * (20px + 2* var(--pwt-spacer-1)) + 2 * var(-= -pwt-spacer-2))") Could be worth a comment IMO, until we have a nicer way to handle this generically. > .render(move |entry: &PveTreeNode| { > let (id, local_id, guest_info, node) =3D match entry { > PveTreeNode::Lxc(r) =3D> {