From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: partially-applied: [PATCH datacenter-manager v2 2/2] server: api: pve firewall: fix permission check
Date: Mon, 31 Aug 2026 09:58:31 +0200 [thread overview]
Message-ID: <DL2YX4UC9TCE.3HVXKQNVOJKDB@proxmox.com> (raw)
In-Reply-To: <20260831070855.568455-3-d.csapak@proxmox.com>
On Mon Aug 31, 2026 at 9:08 AM CEST, Dominik Csapak wrote:
> This is the api call for the overall firewall status, not a specific
> remote, so there isn't a 'remote' parameter to limit us to.
>
> Instead, check the users permission against /resource/{resource} for
> each remote and only show those where the user has permission.
>
> This fixes a 403 error on the firewall panel for non root@pam users.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
applied this one, thanks!
prev parent reply other threads:[~2026-08-31 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 7:08 [PATCH datacenter-manager/proxmox v2 0/2] check privilege paths during compilation Dominik Csapak
2026-08-31 7:08 ` [PATCH proxmox v2 1/2] router: compile time check privilege path parameters for existence Dominik Csapak
2026-08-31 7:08 ` [PATCH datacenter-manager v2 2/2] server: api: pve firewall: fix permission check Dominik Csapak
2026-08-31 7:58 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL2YX4UC9TCE.3HVXKQNVOJKDB@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox