From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 4FB0C1FF09B for ; Mon, 31 Aug 2026 09:58:36 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 06D06213E1; Mon, 31 Aug 2026 09:58:36 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Aug 2026 09:58:31 +0200 Message-Id: To: "Dominik Csapak" , Subject: partially-applied: [PATCH datacenter-manager v2 2/2] server: api: pve firewall: fix permission check From: "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260831070855.568455-1-d.csapak@proxmox.com> <20260831070855.568455-3-d.csapak@proxmox.com> In-Reply-To: <20260831070855.568455-3-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788163098490 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.401 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W3265TMBEBYS6JVBPAGLY2QIDTFT7QEI X-Message-ID-Hash: W3265TMBEBYS6JVBPAGLY2QIDTFT7QEI X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Aug 31, 2026 at 9:08 AM CEST, Dominik Csapak wrote: > This is the api call for the overall firewall status, not a specific > remote, so there isn't a 'remote' parameter to limit us to. > > Instead, check the users permission against /resource/{resource} for > each remote and only show those where the user has permission. > > This fixes a 403 error on the firewall panel for non root@pam users. > > Signed-off-by: Dominik Csapak applied this one, thanks!