Re: [PATCH datacenter-manager v2 18/20] api: subscriptions: use PdmApplication instead of globals

["Michael Köppl" <m.koeppl@proxmox.com>]

On Thu Aug 20, 2026 at 4:52 PM CEST, Lukas Wagner wrote:

[snip]

> +use crate::api_cache::ApiCache;
> +use crate::context::PdmApplication;
>  use crate::metric_collection::top_entities;
>  use crate::{api_cache, connection, views};
>  
> @@ -686,6 +688,7 @@ pub async fn get_subscription_status(
>      verbose: bool,
>      view: Option<String>,
>      rpcenv: &mut dyn RpcEnvironment,
> +    app: State<PdmApplication>,
>  ) -> Result<Vec<RemoteSubscriptions>, Error> {
>      let (remotes_config, _) = pdm_config::remotes::config()?;

Wouldn't it make sense to use

    let (remotes_config, _) = app.remote_config().read()?;

here as well?

>  
> @@ -711,10 +714,11 @@ pub async fn get_subscription_status(
>          }
>  
>          let view = view.clone();
> +        let app_clone = app.clone();
>  
>          let future = async move {
>              let (node_status, error) =
> -                match get_subscription_info_for_remote(&remote, max_age).await {
> +                match get_subscription_info_for_remote(&app_clone, &remote, max_age).await {
>                      Ok(mut node_status) => {
>                          node_status.retain(|node, _| {
>                              if let Some(view) = &view {

[snip]