Re: [PATCH proxmox v2 01/20] router: introduce shared state

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Aug 26, 2026 at 3:12 PM CEST, Michael Köppl wrote:
> On Thu Aug 20, 2026 at 4:52 PM CEST, Lukas Wagner wrote:
>
> [snip]
>
>> diff --git a/proxmox-router/src/lib.rs b/proxmox-router/src/lib.rs
>> index da2f018f..df225d25 100644
>> --- a/proxmox-router/src/lib.rs
>> +++ b/proxmox-router/src/lib.rs
>> @@ -16,6 +16,7 @@ mod permission;
>>  mod router;
>>  mod rpc_environment;
>>  mod serializable_return;
>> +mod shared_state;
>>  
>>  #[doc(inline)]
>>  #[cfg(feature = "server")]
>> @@ -25,6 +26,7 @@ pub use permission::*;
>>  pub use router::*;
>>  pub use rpc_environment::{RpcEnvironment, RpcEnvironmentType};
>>  pub use serializable_return::SerializableReturn;
>> +pub use shared_state::{SharedStateRegistry, State};
>
> Hope I'm not missing something here, but isn't this only defined in
> 3/20? So proxmox-router wouldn't compile until 3/20 is applied as well.
>

yeah, noticed this as well while working on v3. Should be fixed in the
next revision :)

>>  
>>  // make list_subdirs_api_method! work without an explicit proxmox-schema dependency:
>>  #[doc(hidden)]
>> diff --git a/proxmox-router/src/rpc_environment.rs b/proxmox-router/src/rpc_environment.rs
>> index 8ce2d99d..e065504a 100644
>> --- a/proxmox-router/src/rpc_environment.rs
>> +++ b/proxmox-router/src/rpc_environment.rs
>
> [snip]