Re: applied: [PATCH datacenter-manager 1/1] fix #7135: openid auth: improve error logging

["Lukas Wagner" <l.wagner@proxmox.com>]

On Mon Aug 24, 2026 at 12:47 PM CEST, Thomas Ellmenreich wrote:
> On Fri Aug 21, 2026 at 1:35 PM CEST, Lukas Wagner wrote:
>
> [snip]
>
>> Applied, thanks for the patch!
>>
>> I think the way you implemented this makes sense. Having the error with the
>> entire context in the system logs should make troubleshooting way easier. We
>> could still consider returning more details in the API response later, if we
>> desire to, the current change does not limit us from doing so.
>>
>> It appears that PBS suffers from the same issue, could you maybe send a patch
>> for there as well? (cc @Chris)
>
> [snip]
>
> I'm just now looking into this. I decided to also see how PVE handles the
> same situation, and it seems that all three products have a different
> approach. I would propose changing them all to the approach implemented
> with in patch.
>
> The approaches are as follows:
>
> PDM: shows a shallow error in the UI and logs the full error.
> PBS: shows even less information in the UI and doesn't log anything.
> PVE: shows the full error in the UI.
>
> I would create two patches to standardise the approaches to match PDM's
> method. What does everyone else think? @Lukas, @Chris

Seems good to me! I guess PVE could stay as is, although of course it
probably wouldn't hurt to log to syslog as well. But the important part
is that an admin gets *some* idea of what is going wrong, which is
already the case if the full error is returned from the API.

For PBS it definitely makes sense to use the same approach, especially
since it uses the same underlying implementation as PDM.