From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: applied: [PATCH datacenter-manager 1/1] fix #7135: openid auth: improve error logging
Date: Mon, 24 Aug 2026 12:47:37 +0200 [thread overview]
Message-ID: <DKX44SDS7LS6.VFKEEL4ZK7TB@proxmox.com> (raw)
In-Reply-To: <178731214859.187715.588193495057111260.b4-ty@proxmox.com>
On Fri Aug 21, 2026 at 1:35 PM CEST, Lukas Wagner wrote:
[snip]
> Applied, thanks for the patch!
>
> I think the way you implemented this makes sense. Having the error with the
> entire context in the system logs should make troubleshooting way easier. We
> could still consider returning more details in the API response later, if we
> desire to, the current change does not limit us from doing so.
>
> It appears that PBS suffers from the same issue, could you maybe send a patch
> for there as well? (cc @Chris)
[snip]
I'm just now looking into this. I decided to also see how PVE handles the
same situation, and it seems that all three products have a different
approach. I would propose changing them all to the approach implemented
with in patch.
The approaches are as follows:
PDM: shows a shallow error in the UI and logs the full error.
PBS: shows even less information in the UI and doesn't log anything.
PVE: shows the full error in the UI.
I would create two patches to standardise the approaches to match PDM's
method. What does everyone else think? @Lukas, @Chris
next prev parent reply other threads:[~2026-08-24 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 10:21 [PATCH datacenter-manager 1/1] fix #7135: openid auth: improve error logging Thomas Ellmenreich
2026-08-21 11:35 ` applied: " Lukas Wagner
2026-08-24 10:47 ` Thomas Ellmenreich [this message]
2026-08-24 11:01 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKX44SDS7LS6.VFKEEL4ZK7TB@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox