From: "Nicolas Frey" <n.frey@proxmox.com>
To: "Erik Fastermann" <e.fastermann@proxmox.com>,
<pbs-devel@lists.proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox{,-backup,-datacenter-manager} v3 0/5] factor system report into shared crate
Date: Wed, 12 Aug 2026 11:59:58 +0200 [thread overview]
Message-ID: <DKMVLRVHIMPN.B1HCYRKYT0HX@proxmox.com> (raw)
In-Reply-To: <20260811114332.283776-1-e.fastermann@proxmox.com>
On Tue Aug 11, 2026 at 1:43 PM CEST, Erik Fastermann wrote:
> This series moves the system report logic that was duplicated in
> PBS and PDM into a new shared proxmox-system-report crate.
>
> proxmox:
> Adds the proxmox-system-report crate holding the common file,
> command and function collection, the unified section order
> (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands
> run on every product.
>
> proxmox-backup, proxmox-datacenter-manager:
> Drop the duplicated logic and generate the report through the shared
> crate, passing only their product specific files, commands and
> functions.
>
> The report content stays the same apart from two intentional effects
> of sharing one implementation. The top-level section order is now the
> same for both products and the general command set is the union of
> what each ran before. PDM additionally emits FILES first now instead
> of last. Product specific entries are untouched.
>
changes LGTM, gave this a spin on both PBS and PDM, so consider this:
Reviewed-by: Nicolas Frey <n.frey@proxmox.com>
Tested-by: Nicolas Frey <n.frey@proxmox.com>
prev parent reply other threads:[~2026-08-12 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 11:43 [PATCH proxmox{,-backup,-datacenter-manager} v3 0/5] factor system report into shared crate Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox v3 1/5] system-report: add crate for shared report generation Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox-backup v3 2/5] d/control: depend on tools used by the system report Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox-backup v3 3/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox-datacenter-manager v3 4/5] d/control: depend on tools used by the system report Erik Fastermann
2026-08-11 11:43 ` [PATCH proxmox-datacenter-manager v3 5/5] report: use shared proxmox-system-report crate Erik Fastermann
2026-08-12 9:59 ` Nicolas Frey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKMVLRVHIMPN.B1HCYRKYT0HX@proxmox.com \
--to=n.frey@proxmox.com \
--cc=e.fastermann@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox