From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D8D431FF0E5 for ; Wed, 12 Aug 2026 12:00:02 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 107F121598; Wed, 12 Aug 2026 12:00:02 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 12 Aug 2026 11:59:58 +0200 Message-Id: Subject: Re: [PATCH proxmox{,-backup,-datacenter-manager} v3 0/5] factor system report into shared crate From: "Nicolas Frey" To: "Erik Fastermann" , , X-Mailer: aerc 0.20.0 References: <20260811114332.283776-1-e.fastermann@proxmox.com> In-Reply-To: <20260811114332.283776-1-e.fastermann@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786528783962 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.561 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2IQK2OL6CBE755ZFVPGCRXFQAPPPDUBL X-Message-ID-Hash: 2IQK2OL6CBE755ZFVPGCRXFQAPPPDUBL X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Aug 11, 2026 at 1:43 PM CEST, Erik Fastermann wrote: > This series moves the system report logic that was duplicated in > PBS and PDM into a new shared proxmox-system-report crate. > > proxmox: > Adds the proxmox-system-report crate holding the common file, > command and function collection, the unified section order > (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands > run on every product. > > proxmox-backup, proxmox-datacenter-manager: > Drop the duplicated logic and generate the report through the shared > crate, passing only their product specific files, commands and > functions. > > The report content stays the same apart from two intentional effects > of sharing one implementation. The top-level section order is now the > same for both products and the general command set is the union of > what each ran before. PDM additionally emits FILES first now instead > of last. Product specific entries are untouched. > changes LGTM, gave this a spin on both PBS and PDM, so consider this: Reviewed-by: Nicolas Frey Tested-by: Nicolas Frey