public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: applied: [PATCH datacenter-manager] ui: views: map: fix force reload of location data
Date: Tue, 26 May 2026 13:24:37 +0200	[thread overview]
Message-ID: <DISKK3KJX197.1IK4RBAMHE4D6@proxmox.com> (raw)
In-Reply-To: <20260526093615.1433585-1-d.csapak@proxmox.com>

On Tue May 26, 2026 at 11:35 AM CEST, Dominik Csapak wrote:
> we don't use 'max-age = 0' for a force refresh (when a user clicks the
> refresh button). Instead we use FORCE_RELOAD_MAX_AGE_S, so use that
> instead to gate the max-age property.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/dashboard/view.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs
> index a654d1be..76e75e2c 100644
> --- a/ui/src/dashboard/view.rs
> +++ b/ui/src/dashboard/view.rs
> @@ -261,8 +261,8 @@ impl ViewComp {
>                          let mut params = json!({});
>                          // max-age for location has a sensible backend default and does not need to be
>                          // updated as often, except if forced
> -                        if max_age == 0 {
> -                            params["max-age"] = 0.into();
> +                        if max_age <= FORCE_RELOAD_MAX_AGE_S {
> +                            params["max-age"] = max_age.into();
>                          }
>                          add_view_filter(&mut params);
>                          let res = http_get("/resources/location-info", Some(params)).await;


applied, thanks!




      reply	other threads:[~2026-05-26 11:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  9:35 [PATCH datacenter-manager] ui: views: map: fix force reload of location data Dominik Csapak
2026-05-26 11:24 ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DISKK3KJX197.1IK4RBAMHE4D6@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal