From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 60A871FF146 for ; Tue, 26 May 2026 13:25:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 618131B051; Tue, 26 May 2026 13:25:24 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 13:24:37 +0200 Message-Id: To: "Dominik Csapak" , Subject: applied: [PATCH datacenter-manager] ui: views: map: fix force reload of location data From: "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260526093615.1433585-1-d.csapak@proxmox.com> In-Reply-To: <20260526093615.1433585-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779794653496 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [view.rs] Message-ID-Hash: HRBBZX2YD63BBLU4RA63ND27P4PWKVHB X-Message-ID-Hash: HRBBZX2YD63BBLU4RA63ND27P4PWKVHB X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 26, 2026 at 11:35 AM CEST, Dominik Csapak wrote: > we don't use 'max-age =3D 0' for a force refresh (when a user clicks the > refresh button). Instead we use FORCE_RELOAD_MAX_AGE_S, so use that > instead to gate the max-age property. > > Signed-off-by: Dominik Csapak > --- > ui/src/dashboard/view.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs > index a654d1be..76e75e2c 100644 > --- a/ui/src/dashboard/view.rs > +++ b/ui/src/dashboard/view.rs > @@ -261,8 +261,8 @@ impl ViewComp { > let mut params =3D json!({}); > // max-age for location has a sensible backend d= efault and does not need to be > // updated as often, except if forced > - if max_age =3D=3D 0 { > - params["max-age"] =3D 0.into(); > + if max_age <=3D FORCE_RELOAD_MAX_AGE_S { > + params["max-age"] =3D max_age.into(); > } > add_view_filter(&mut params); > let res =3D http_get("/resources/location-info",= Some(params)).await; applied, thanks!