From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>,
<pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v2 1/4] api: return global cpu/memory/storage statistics
Date: Thu, 02 Apr 2026 15:48:05 +0200 [thread overview]
Message-ID: <DHIPSINH4HWK.2R1RLWU1IHX3L@proxmox.com> (raw)
In-Reply-To: <1fc88a7c-1b5d-4426-bf18-6a1b3d245e66@proxmox.com>
On Thu Apr 2, 2026 at 3:02 PM CEST, Dominik Csapak wrote:
>>> +#[api]
>>> +#[derive(Default, Serialize, Deserialize, Clone, PartialEq)]
>>> +/// Statistics for CPU utilization
>>> +pub struct CpuStatistics {
>>> + /// Amount of threads utilized
>>
>> 'thread' is a countable noun, so it should rather be "Number of threads"
>
> thanks, i'll fix it, but just to note, in that same file we have
> many instances of this, for example:
>
> "Amount of running guests"
> "Amount of online datastores"
> "Amount of configured remotes"
>
>
> which all seem to me like countable nouns?
>
> so we might want to clean that up for all of them
Yeah, this would make sense! Feel free to include it as a separate patch
in this series :)
next prev parent reply other threads:[~2026-04-02 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 13:07 [PATCH datacenter-manager v2 0/4] add resource gauge panels to dashboard/views Dominik Csapak
2026-03-30 13:07 ` [PATCH datacenter-manager v2 1/4] api: return global cpu/memory/storage statistics Dominik Csapak
2026-04-01 11:34 ` Lukas Wagner
2026-04-02 13:02 ` Dominik Csapak
2026-04-02 13:48 ` Lukas Wagner [this message]
2026-03-30 13:07 ` [PATCH datacenter-manager v2 2/4] ui: css: use mask for svg icons Dominik Csapak
2026-03-30 13:07 ` [PATCH datacenter-manager v2 3/4] ui: dashboard: add new gauge panels widget type Dominik Csapak
2026-04-01 11:34 ` Lukas Wagner
2026-04-01 11:36 ` Lukas Wagner
2026-03-30 13:07 ` [PATCH datacenter-manager v2 4/4] ui: dashboard: add resource gauges to default dashboard Dominik Csapak
2026-04-01 11:34 ` [PATCH datacenter-manager v2 0/4] add resource gauge panels to dashboard/views Lukas Wagner
2026-04-02 13:24 ` superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHIPSINH4HWK.2R1RLWU1IHX3L@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox