public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel
@ 2026-03-09 14:37 Dominik Csapak
  2026-04-02 10:55 ` Lukas Wagner
  0 siblings, 1 reply; 3+ messages in thread
From: Dominik Csapak @ 2026-03-09 14:37 UTC (permalink / raw)
  To: pdm-devel

Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply
use the 'node' one, since there can only be one for PBS anyway.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/pbs/node/mod.rs | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
index abb1f6a6..6d2f46b8 100644
--- a/ui/src/pbs/node/mod.rs
+++ b/ui/src/pbs/node/mod.rs
@@ -17,7 +17,7 @@ pub(crate) mod overview;
 
 use overview::PbsNodeOverviewPanel;
 
-use crate::get_deep_url_low_level;
+use crate::{get_deep_url_low_level, remotes::RemoteTaskList};
 
 #[derive(Clone, Debug, Eq, PartialEq, Properties)]
 pub struct PbsNodePanel {
@@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp {
                     move |_| PbsNodeOverviewPanel::new(remote.clone()).into()
                 },
             )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("tasks_view")
+                    .label(tr!("Tasks"))
+                    .icon_class("fa fa-list"),
+                {
+                    let remote = props.remote.clone();
+                    move |_| RemoteTaskList::new().remote(remote.clone()).into()
+                },
+            )
             .with_item_builder(
                 TabBarItem::new()
                     .key("update_view")
-- 
2.47.3





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel
  2026-03-09 14:37 [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel Dominik Csapak
@ 2026-04-02 10:55 ` Lukas Wagner
  2026-04-02 11:09   ` Dominik Csapak
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Wagner @ 2026-04-02 10:55 UTC (permalink / raw)
  To: Dominik Csapak, pdm-devel

On Mon Mar 9, 2026 at 3:37 PM CET, Dominik Csapak wrote:
> Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply
> use the 'node' one, since there can only be one for PBS anyway.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/pbs/node/mod.rs | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
> index abb1f6a6..6d2f46b8 100644
> --- a/ui/src/pbs/node/mod.rs
> +++ b/ui/src/pbs/node/mod.rs
> @@ -17,7 +17,7 @@ pub(crate) mod overview;
>  
>  use overview::PbsNodeOverviewPanel;
>  
> -use crate::get_deep_url_low_level;
> +use crate::{get_deep_url_low_level, remotes::RemoteTaskList};
>  
>  #[derive(Clone, Debug, Eq, PartialEq, Properties)]
>  pub struct PbsNodePanel {
> @@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp {
>                      move |_| PbsNodeOverviewPanel::new(remote.clone()).into()
>                  },
>              )
> +            .with_item_builder(
> +                TabBarItem::new()
> +                    .key("tasks_view")
> +                    .label(tr!("Tasks"))
> +                    .icon_class("fa fa-list"),
> +                {
> +                    let remote = props.remote.clone();
> +                    move |_| RemoteTaskList::new().remote(remote.clone()).into()
> +                },
> +            )
>              .with_item_builder(
>                  TabBarItem::new()
>                      .key("update_view")

I wonder, should we also add a 'per-node' Tasks tab for PVE remotes?
What do you think?





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel
  2026-04-02 10:55 ` Lukas Wagner
@ 2026-04-02 11:09   ` Dominik Csapak
  0 siblings, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-04-02 11:09 UTC (permalink / raw)
  To: Lukas Wagner, pdm-devel



On 4/2/26 12:54 PM, Lukas Wagner wrote:
> On Mon Mar 9, 2026 at 3:37 PM CET, Dominik Csapak wrote:
>> Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply
>> use the 'node' one, since there can only be one for PBS anyway.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   ui/src/pbs/node/mod.rs | 12 +++++++++++-
>>   1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
>> index abb1f6a6..6d2f46b8 100644
>> --- a/ui/src/pbs/node/mod.rs
>> +++ b/ui/src/pbs/node/mod.rs
>> @@ -17,7 +17,7 @@ pub(crate) mod overview;
>>   
>>   use overview::PbsNodeOverviewPanel;
>>   
>> -use crate::get_deep_url_low_level;
>> +use crate::{get_deep_url_low_level, remotes::RemoteTaskList};
>>   
>>   #[derive(Clone, Debug, Eq, PartialEq, Properties)]
>>   pub struct PbsNodePanel {
>> @@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp {
>>                       move |_| PbsNodeOverviewPanel::new(remote.clone()).into()
>>                   },
>>               )
>> +            .with_item_builder(
>> +                TabBarItem::new()
>> +                    .key("tasks_view")
>> +                    .label(tr!("Tasks"))
>> +                    .icon_class("fa fa-list"),
>> +                {
>> +                    let remote = props.remote.clone();
>> +                    move |_| RemoteTaskList::new().remote(remote.clone()).into()
>> +                },
>> +            )
>>               .with_item_builder(
>>                   TabBarItem::new()
>>                       .key("update_view")
> 
> I wonder, should we also add a 'per-node' Tasks tab for PVE remotes?
> What do you think?
> 

mhmm can make sense, but maybe a better option would be to add a node
selector to the tasks on datacenter level? (maybe both?)

I just fear that we might overload the interface with too many options
if we do this for everything (but that fear might be unfounded :P )




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-02 11:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-09 14:37 [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel Dominik Csapak
2026-04-02 10:55 ` Lukas Wagner
2026-04-02 11:09   ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal