From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pdm-devel@lists.proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>
Subject: Re: applied: [PATCH datacenter-manager 1/2] add `make tidy` target
Date: Thu, 26 Mar 2026 09:20:12 +0100 [thread overview]
Message-ID: <DHCKFNV3DPSD.1QNE710QGQGZM@proxmox.com> (raw)
In-Reply-To: <177445770876.3365226.15945212122448861914.b4-ty@proxmox.com>
On Wed Mar 25, 2026 at 5:55 PM CET, Thomas Lamprecht wrote:
> Side-note: would using --all for fmt make any difference here? Only checked the
> output of `cargo fmt -h` which mentions "Format all packages, and also their
> local path-based dependencies", which might be relevant here for the workspace
> local lib dependencies?
>
I tried this out before sending the patch. It seems like the `--all`
flag does not make a difference for us, in my experiments a regular
`cargo fmt` would also format all workspace members just fine, so
I left it at that.
prev parent reply other threads:[~2026-03-26 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 13:44 Lukas Wagner
2026-03-25 13:44 ` [PATCH datacenter-manager 2/2] add missing .PHONY for the 'test' make target Lukas Wagner
2026-03-25 16:55 ` applied: [PATCH datacenter-manager 1/2] add `make tidy` target Thomas Lamprecht
2026-03-26 8:20 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHCKFNV3DPSD.1QNE710QGQGZM@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox