Re: [PATCH datacenter-manager/proxmox{,-backup,-yew-comp} 00/26] metric collection for the PDM host

["Lukas Wagner" <l.wagner@proxmox.com>]

On Mon Mar 16, 2026 at 2:42 PM CET, Arthur Bied-Charreton wrote:
> On Thu, Mar 12, 2026 at 02:52:01PM +0100, Lukas Wagner wrote:
>> This series add metric collection physical PDM hosts.
>> 
>> The patches for `proxmox` introduce three new crates:
>>   - proxmox-disks: broken out from proxmox-backup, needed to read disk stats
>>   - proxmox-parallel-handler: also broken out from proxmox-backup,
>>     needed as a dependency for proxmox-disks. Since the scope was manageable,
>>     this series improves the existing code a bit by adding a dedicated error type,
>>     some documentation and basic unit tests
>>   - proxmox-procfs: as a new home for any procfs related modules. this patch series adds
>>     a `pressure` module for reading pressure stall information for the host and cgroups.
>>     The general idea is that we should move other procfs helpers from proxmox-sys into
>>     this new crate, but to avoid scope explosion this is not done as a part of this
>>     series
>> 
>> The patches for proxmox-backup just switch over to the new moved implementations of proxmox-disks
>> and proxmox-parallel-handler.
>> 
>> The patches for proxmox-yew-comp slight adapt the existing NodeStatusPanel to allow the application
>> to inject child components into the same panel.
>> 
>> The proxmox-datacenter-manager patches do some initial refactoring (naming), and then add the needed
>> collection loop, API types and UI elements.
> [...]
>
> Looks very nice, gave this a spin on my PDM VM, everything works, the
> metrics are being collected & updated, and they are consistent with what 
> I see on my machine.
>
> Responded to some patches directly with some comments, modulo that
> consider this series:
>
> Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>

Thanks for the review, Arthur!

I'll try to send a v2 with these minor improvements in the next days,
I'll include your T-b and R-b trailers there!