From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Arthur Bied-Charreton" <a.bied-charreton@proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox 06/26] disks: import from Proxmox Backup Server
Date: Wed, 18 Mar 2026 14:54:38 +0100 [thread overview]
Message-ID: <DH5YJD50686Y.2H6BP9GX1OGMQ@proxmox.com> (raw)
In-Reply-To: <qkzzlmnmmnoc4epivyxx5tkwyaaiqty3asugtbp3tubru5pne4@5ewvdc2y5rtq>
On Mon Mar 16, 2026 at 2:13 PM CET, Arthur Bied-Charreton wrote:
> On Thu, Mar 12, 2026 at 02:52:07PM +0100, Lukas Wagner wrote:
>> This is based on the disks module from PBS and left unchanged.
>>
>> The version has not been set to 1.0 yet since it seems like this crate
>> could use a bit a cleanup (custom error type instead of anyhow,
>> documentation).
>>
> LGTM besides one small copy paste error, comment inline
>> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
>> ---
>> Cargo.toml | 6 +
>> proxmox-disks/Cargo.toml | 30 +
>> proxmox-disks/debian/changelog | 5 +
>> proxmox-disks/debian/control | 94 ++
>> proxmox-disks/debian/copyright | 18 +
>> proxmox-disks/debian/debcargo.toml | 7 +
>> proxmox-disks/src/lib.rs | 1396 ++++++++++++++++++++++++++++
>> proxmox-disks/src/lvm.rs | 60 ++
>> proxmox-disks/src/parse_helpers.rs | 52 ++
>> proxmox-disks/src/smart.rs | 227 +++++
>> proxmox-disks/src/zfs.rs | 205 ++++
>> proxmox-disks/src/zpool_list.rs | 294 ++++++
>> proxmox-disks/src/zpool_status.rs | 496 ++++++++++
>> 13 files changed, 2890 insertions(+)
>> create mode 100644 proxmox-disks/Cargo.toml
>> create mode 100644 proxmox-disks/debian/changelog
>> create mode 100644 proxmox-disks/debian/control
>> create mode 100644 proxmox-disks/debian/copyright
>> create mode 100644 proxmox-disks/debian/debcargo.toml
>> create mode 100644 proxmox-disks/src/lib.rs
>> create mode 100644 proxmox-disks/src/lvm.rs
>> create mode 100644 proxmox-disks/src/parse_helpers.rs
>> create mode 100644 proxmox-disks/src/smart.rs
>> create mode 100644 proxmox-disks/src/zfs.rs
>> create mode 100644 proxmox-disks/src/zpool_list.rs
>> create mode 100644 proxmox-disks/src/zpool_status.rs
>>
> [...]
>> @@ -154,6 +159,7 @@ proxmox-async = { version = "0.5.0", path = "proxmox-async" }
>> proxmox-base64 = { version = "1.0.0", path = "proxmox-base64" }
>> proxmox-compression = { version = "1.0.0", path = "proxmox-compression" }
>> proxmox-daemon = { version = "1.0.0", path = "proxmox-daemon" }
>> +proxmox-disks = { version = "0.1.0", path = "proxmox-daemon" }
> Should probably be proxmox-disks :)
Yes, thanks!
Probably didn't notice it because no crate in the workspace actually
depends on proxmox-disks...
>> proxmox-fixed-string = { version = "0.1.0", path = "proxmox-fixed-string" }
>> proxmox-http = { version = "1.0.5", path = "proxmox-http" }
>> proxmox-http-error = { version = "1.0.0", path = "proxmox-http-error" }
> [...]
next prev parent reply other threads:[~2026-03-18 13:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 13:52 [PATCH datacenter-manager/proxmox{,-backup,-yew-comp} 00/26] metric collection for the PDM host Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 01/26] sys: procfs: don't read from sysfs during unit tests Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 02/26] parallel-handler: import code from Proxmox Backup Server Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 03/26] parallel-handler: introduce custom error type Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 04/26] parallel-handler: add documentation Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 05/26] parallel-handler: add simple unit-test suite Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 06/26] disks: import from Proxmox Backup Server Lukas Wagner
2026-03-16 13:13 ` Arthur Bied-Charreton
2026-03-18 13:54 ` Lukas Wagner [this message]
2026-03-12 13:52 ` [PATCH proxmox 07/26] disks: fix typo in `initialize_gpt_disk` Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 08/26] disks: add parts of gather_disk_stats from PBS Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 09/26] disks: gate api macro behind 'api-types' feature Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 10/26] disks: clippy: collapse if-let chains where possible Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 11/26] procfs: add helpers for querying pressure stall information Lukas Wagner
2026-03-16 13:25 ` Arthur Bied-Charreton
2026-03-18 14:08 ` Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox 12/26] time: use u64 parse helper from nom Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox-backup 13/26] tools: move ParallelHandler to new proxmox-parallel-handler crate Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox-backup 14/26] tools: replace disks module with proxmox-disks Lukas Wagner
2026-03-16 13:27 ` Arthur Bied-Charreton
2026-03-18 14:08 ` Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox-backup 15/26] metric collection: use blockdev_stat_for_path from proxmox_disks Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox-yew-comp 16/26] node status panel: add `children` property Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox-yew-comp 17/26] RRDGrid: fix size observer by attaching node reference to rendered container Lukas Wagner
2026-03-12 13:52 ` [PATCH proxmox-yew-comp 18/26] RRDGrid: add padding and increase gap between elements Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 19/26] metric collection: clarify naming for remote metric collection Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 20/26] metric collection: fix minor typo in error message Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 21/26] metric collection: collect PDM host metrics in a new collection task Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 22/26] api: fix /nodes/localhost/rrddata endpoint Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 23/26] pdm: node rrd data: rename 'total-time' to 'metric-collection-total-time' Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 24/26] pdm-api-types: add PDM host metric fields Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 25/26] ui: node status: add RRD graphs for PDM host metrics Lukas Wagner
2026-03-12 13:52 ` [PATCH datacenter-manager 26/26] ui: lxc/qemu/node: use RRD value render helpers Lukas Wagner
2026-03-16 13:42 ` [PATCH datacenter-manager/proxmox{,-backup,-yew-comp} 00/26] metric collection for the PDM host Arthur Bied-Charreton
2026-03-18 14:09 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH5YJD50686Y.2H6BP9GX1OGMQ@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox