Re: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Feb 18, 2026 at 5:41 PM CET, Shan Shaji wrote:
> If a user removed a remote without deleting its associated token,
> PDM would not allow re-adding the same remote unless the token
> was changed. To fix this, support for optionally deleting the token
> on the remote has been added.
>
> new changes:
> - use ConfirmDialog widget for creating the confirmation dialog.
> - add token deletion as opt-out feature.
>
> History
> =======
>
> changes since v3: Thanks @Lukas and @Maximiliano
> - addressed nit comments.
> - percent-encode the `userid` parameter.
> - rename PbsClient's delete_admin_token function to delete_token.
> - by default set the CLIs `delete-token` option to `true`. So by default
>   the token will be deleted unless the option is set to false.
> - remove `type` attribute from the `delete-token` schema.
> - fix the alignment of checkbox and text.
>
> changes since v2:
> - regenerate the `delete_token` method. The new generate code has
>   `percent_encoding` wrapped around the params to handle non-alphanumeric
>   characters. 
>
> changes since v3:
> - locked the remote config inorder to avoid race condition. Thanks @Michael
> - included missing admin cli implementation. Thanks @Michael
> - addressed nit comments. Thanks @Shannon
>

LGTM!

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>