Re: [PATCH datacenter-manager v3 6/6] cli: admin: add `delete-token` option to delete token from remote

["Lukas Wagner" <l.wagner@proxmox.com>]

Hi Shan,

thanks for the patch. Some notes inline.

On Wed Feb 11, 2026 at 4:20 PM CET, Shan Shaji wrote:
> Inorder to allow deleting the remote API token from PDM, added optional
> boolean flag.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
>  **note**: No changes since v2. This was not included in v1.  
>
>  cli/admin/src/remotes.rs | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/cli/admin/src/remotes.rs b/cli/admin/src/remotes.rs
> index edd3fd8..6702667 100644
> --- a/cli/admin/src/remotes.rs
> +++ b/cli/admin/src/remotes.rs
> @@ -217,16 +217,28 @@ fn update_remote(
>      input: {
>          properties: {
>              id: { schema: REMOTE_ID_SCHEMA },
> +            "delete-token": {
> +                type: bool,
> +                optional: true,
> +                description: "Remove the API-Token from remote."

Same thing here that I already elaborated on in the client CLI tool:
  - type
  - default
  - description

> +            }
>          }
>      }
>  )]
> -/// Add a new remote.
> -fn remove_remote(id: String, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
> -    let param = json!({ "id": id });
> +/// Remove a new remote.
> +async fn remove_remote(
> +    id: String,
> +    delete_token: Option<bool>,
> +    rpcenv: &mut dyn RpcEnvironment,
> +) -> Result<(), Error> {
> +    let mut param = json!({ "id": id });
> +    if delete_token.is_some() {
> +        param["delete-token"] = delete_token.into();
> +    }
>  
>      let info = &dc_api::remotes::API_METHOD_REMOVE_REMOTE;
>      match info.handler {
> -        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv).map(drop),
> +        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await.map(drop),
>          _ => unreachable!(),
>      }
>  }