Re: [PATCH datacenter-manager v3 3/6] pdm-client: accept `delete-token` argument for deleting api token

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Feb 11, 2026 at 4:20 PM CET, Shan Shaji wrote:
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
> changes since v2: No changes. 
> changes since v1:
>  - reformated using `rustfmt`.
>  - added doc comment.
>
>  lib/pdm-client/src/lib.rs | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs
> index 01ee6f7..ef534cc 100644
> --- a/lib/pdm-client/src/lib.rs
> +++ b/lib/pdm-client/src/lib.rs
> @@ -136,8 +136,15 @@ impl<T: HttpApiClient> PdmClient<T> {
>          Ok(())
>      }
>  
> -    pub async fn delete_remote(&self, remote: &str) -> Result<(), Error> {
> -        let path = format!("/api2/extjs/remotes/remote/{remote}");
> +    /// Deletes a remote, with optional support to also delete the associated token.
> +    pub async fn delete_remote(
> +        &self,
> +        remote: &str,
> +        delete_token: &Option<bool>,

This can just be `Option<bool>`.

In general, passing &Option<T> is often a bit of an antipattern, instead
it's more idiomatic to pass Option<&T>. If the caller has a &Option<T>,
they can always call Option::as_ref to get Option<&T> [1].

In this concrete case here, since `bool` is Copy [2], its best to just use
Option<bool>.

[1] https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref
[2] https://doc.rust-lang.org/std/marker/trait.Copy.html

> +    ) -> Result<(), Error> {
> +        let path = ApiPathBuilder::new(format!("/api2/extjs/remotes/remote/{remote}"))
> +            .maybe_arg("delete-token", delete_token)
> +            .build();
>          self.0.delete(&path).await?.nodata()?;
>          Ok(())
>      }